Repository navigation
Conversation
|
@fghaas thank you for your excellent PR. I would merge it as-is if the tests wouldn't fail. The failure seems unrelated to your work. |
|
@maikhoepfel The PR is hardly my work at all; all credit should go to @nfletton. Would you mind explaining what you mean by running against my own branch? Run what, exactly? |
|
@fghaas Sorry for not being clear enough. I suppose what I was asking is how urgent merging your PR is. I assumed that in your project, instead of adding |
|
@maikhoepfel As it turns out, django-compressor removed support for Django 1.7 before their recent 2.0 release (see django-compressor/django-compressor@e27fce7). I don't know where exactly this dependency gets pulled in, but if you want the tests to complete on Django 1.7, it would appear that you would have to specify an explicit dependency on django-compressor 1.6. |
|
Blocked by #122. |
When the RedirectView is used in combination with another CheckoutSessionMixin defined for a DeferredTax taxation strategy, then submission's basket object has critical tax information, whereas request.basket does not. Change RedirectView's basket reference to point to build_submission()['basket']. Fixes django-oscar#98, reported by Nigel Fletton.
|
Cherry-picked in be89e19. Thank you for all your work on this! |
|
Ah, ok. I had just rebased my branch on master and initiated another Travis build. Never mind then. :) |
|
Haha, you're too quick. Do you need a release? |
|
You may want to look into #124 before you consider cutting a release. :) |
|
OK if everything is indeed fine with the Travis build, then yes a release would be great. Thanks! |
|
@fghaas Just pushed a release. Thank you for your work on this! |
|
@maikhoepfel While this did fix the original issue (meaning taxes are applied to the total amount before sending the transaction off to PayPal), I'm still struggling with the taxes getting lost from the order after PayPal payment has been authorized. I'm currently trying to find out whether it's my CheckoutSessionMixin doing this, or whether something is still broken in the PayPal module. |
|
Also, cancelling a PayPal order leaves the basket behind empty, as if the order actually went through; that's not exactly desirable either. Edit: I should clarify: cancelling the order in PayPal works fine. Cancelling the order in preview is what leaves the basket empty. Not sure if that's desired. |
When the RedirectView is used in combination with another
CheckoutSessionMixin defined for a DeferredTax taxation strategy, then
submission's basket object has critical tax information, whereas
request.basket does not. Change RedirectView's basket reference to
point to build_submission()['basket'].
Fixes #98, reported by Nigel Fletton.