This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Add IOutstationApplication::OnConfirmProcess to C++, C#, and Java#403
Merged
jadamcrain merged 2 commits intodevelopfrom Oct 16, 2020
Merged
Add IOutstationApplication::OnConfirmProcess to C++, C#, and Java#403jadamcrain merged 2 commits intodevelopfrom
jadamcrain merged 2 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## release #403 +/- ##
===========================================
+ Coverage 51.69% 51.75% +0.05%
===========================================
Files 456 456
Lines 13602 13609 +7
===========================================
+ Hits 7032 7043 +11
+ Misses 6570 6566 -4
Continue to review full report at Codecov.
|
emgre
added a commit
to dnp3/opendnp3-dnp4s-driver
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first stab at adding this feature. It was straightforward as the callback is only invoked from two places in OutstationStates.cpp
We might consider adding some tests to this PR to verify.