Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Deprecate LinkConfig constructor with an unused useConfirms argument. - #439

Merged
emgre merged 2 commits into
developfrom
bugifx/deprecate-link-config-unused-param
Apr 21, 2022
Merged

Deprecate LinkConfig constructor with an unused useConfirms argument.#439
emgre merged 2 commits into
developfrom
bugifx/deprecate-link-config-unused-param

Conversation

@emgre

@emgre emgre commented Apr 18, 2022

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Apr 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #439 (c87d6df) into develop (e8b1de4) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head c87d6df differs from pull request most recent head 8f72ac8. Consider uploading reports for the commit 8f72ac8 to get more accurate results

@@             Coverage Diff             @@
##           develop     #439      +/-   ##
===========================================
- Coverage    51.36%   51.34%   -0.03%     
===========================================
  Files          423      423              
  Lines        13444    13444              
===========================================
- Hits          6906     6903       -3     
- Misses        6538     6541       +3     
Impacted Files Coverage Δ
cpp/lib/include/opendnp3/link/LinkConfig.h 0.00% <0.00%> (ø)
...pp/lib/include/opendnp3/master/MasterStackConfig.h 0.00% <0.00%> (ø)
cpp/lib/src/app/PrefixedWriteIterator.h 95.23% <0.00%> (-4.77%) ⬇️
cpp/lib/src/gen/LinkFunction.cpp 65.82% <0.00%> (-2.54%) ⬇️
cpp/lib/src/app/parsing/CountIndexParser.cpp 59.74% <0.00%> (-0.65%) ⬇️
cpp/lib/src/transport/TransportLayer.cpp 95.31% <0.00%> (+1.56%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@emgre
emgre merged commit 2de49fa into develop Apr 21, 2022
@emgre
emgre deleted the bugifx/deprecate-link-config-unused-param branch April 22, 2022 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant