This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Fix EventOnly behaviour (Reprise) - #386
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #386 +/- ##
===========================================
- Coverage 51.72% 51.69% -0.03%
===========================================
Files 456 456
Lines 13602 13602
===========================================
- Hits 7036 7032 -4
- Misses 6566 6570 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #384 (Reprise).
The fix in #385 was not enough, since it kept reporting the old static value. I added unit tests that verify both the static and the event value to make sure this fix works.