Repository navigation
Conversation
Consume typed prune object events from the SDK result and print confirmed deletions as they arrive. Preserve final reclaimed-space totals and JSON fallback without repeating a destructive request. Signed-off-by: Rob Moss <15984835+robmoss2k@users.noreply.github.com>
robmoss2k
force-pushed
the
32193-prune-progress
branch
from
October 12, 2026 13:52
f4e0874 to
ced9ae0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: moby/moby#32193
Summary
Print confirmed deletions as prune operations progress, including
system prune, while preserving existing headings and final reclaimed-space totals. Consume typed prune events through the SDK result. Use the final JSON report for older API versions or response authorization fallback, without sending another prune request.Dependent draft: requires moby/moby#53894 and publication of its API/SDK modules, followed by a normal dependency update. The currently pinned public SDK does not contain the new result methods; this draft cannot yet build independently.
AI assistance: Codex wrote most of this revision, its tests, documentation, and this description; performed self-review; and ran the automated checks. The human contributor reviewed the original implementation and this revision before publication.
Validation and limits
Rebased onto master
e4078058de0a. The isolated proof checkout uses the revised API/SDK as normally vendored unpublished module fixtures; submitted dependencies are unchanged.The complete upstream CI matrix has not run for this revision. Native Windows focused tests and builds were refreshed; populated live Windows daemon tests, native ARM runtime, and rootless runtime have not been repeated for this refactor. Earlier Windows runtime evidence belongs to the previously reviewed implementation and is not claimed as proof of this revision.
CLI validation uses normally vendored, unpublished API/SDK module fixtures in an isolated proof checkout; no fake module versions or local replacement are submitted. The CLI remains a dependent draft until the API and SDK modules can be published and its normal dependency update can be committed. Its currently pinned public SDK does not contain this feature, so its submitted branch cannot yet compile independently.
Release notes (optional)
Created with: Codex