Repository navigation
Update for Doctrine Coding Standards 4.0 - #2
Merged
Merged
Conversation
jwage
force-pushed
the
doctrine-coding-standards
branch
from
June 8, 2018 20:10
1efa319 to
a9985d2
Compare
Majkl578
reviewed
Jun 8, 2018
Majkl578
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall, just some leftovers that are not handled by our CS currently.
| { | ||
| "name": "squizlabs/php_codesniffer", | ||
| "version": "3.2.3", | ||
| "version": "3.3.0", |
Contributor
There was a problem hiding this comment.
Can you keep the 3.2.3 version here the same way as we did last time?
| /** | ||
| * Abstract implementation of the ManagerRegistry contract. | ||
| * | ||
| * @link www.doctrine-project.org |
Contributor
There was a problem hiding this comment.
We can safely remove all @link www.doctrine-project.org.
(This annotation isn't forbidden by our CS as it may contain useful information so it needs to be done manually - one nice regexp :) .)
| * Constructor. | ||
| * | ||
| * | ||
| * @param ObjectManager $objectManager The object manager. |
Contributor
There was a problem hiding this comment.
Unfortunately we currently have no sniff for phpDoc spacing so some fixers leave superfluous empty lines:
- empty line(s) after
/** - empty line(s) before `*/
- multiple empty lines instead of single empty line
Can you grep through these manually? It's slightly annoying, but doable with three regexes.
jwage
force-pushed
the
doctrine-coding-standards
branch
2 times, most recently
from
June 8, 2018 20:48
c55ba99 to
2adcf99
Compare
jwage
force-pushed
the
doctrine-coding-standards
branch
from
June 8, 2018 21:04
2adcf99 to
6f467e7
Compare
Majkl578
approved these changes
Jun 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.