Repository navigation
Conversation
- Reconstruct MakeWanWanTumble, MakeKameTumble, MakeStarTumble, MakeDashTumble, DoTumble, DoPakunTumble, DoHanaTumble, MakePoiHanaTumble, DoShootCrashCrl, DoTumbleCrl, DoAfterTumbleCrl. - Add ItemObj::getPos(TVec3f*) inline body so it emits in this TU. - MakePoiHanaTumble uses TKartThrower getThrowPow()/getThrowDir() and the s32->float double-magic conversion; force f31 accumulation via a named 5.0f constant. Unit main/Yamamoto/KartTumble now 15/15 matched (100%).
Author
|
Those switch statements look very suspect as well... |
KartTumble.cpp now matches the target at 100% (15/15 functions), so enable it for linking in the matching DOL build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, after discussing with some people on Discord, I let OpenCode loose on
KartTumbleas an experiment. Full disclosure, this code was 100% written by an LLM with no human intervention in about an hour. I have deliberately left it unchanged. I know C++ but I'm not an experienced decomper so I can not judge the quality. The only thing that jumps out at me is the type of the_14member, and obviously variable names could be improved. Let me know if you want me to try improving this or if this kind of PR is unwanted :)