Improve support for View Transitions, Restoration animations, and better Examples - #6
Merged
Conversation
Plus properly fix animationTurn completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved Support for View Transitions
Standard (non-View Transition) CSS animations can be used alongside View Transitions, rather than the factory swithcing between
Turntypes. When supported and enabled, The flow will be as follows:The architecture has been altered to make this change work. Turn classes are no longer responsible for tracking whether a render is a preview, a post-preview, or a direct one. This responsibility now lies with the
Controller, which translates Turbo events into method calls on Turn instances.Expanded Class Names + Restoration Animations
On the HTML element:
turn-view-transitionsandturn-no-view-transitionsfor customising animations based on View Transition supportturn-advance,turn-restore,turn-replacefor customising animations based on the Turbo Visit action: this enables support for animating restoration visitsturn-before-transition,turn-transitionfor customising animations during a View TransitionBetter Examples
Examples have been overhauled to better demonstrate various use cases with and without View Transitions