Migrate to ESLint flat config (eslint-config-domdomegg v2) - #13
Merged
Merged
Conversation
Bump eslint-config-domdomegg to ^2 and eslint to ^9, replace the legacy eslintConfig/.eslintrc with a flat eslint.config.mjs, and reformat sources to the preset's style via `eslint --fix`. The large source diff is entirely mechanical reindentation — no logic changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates ESLint from
eslint-config-domdomeggv1 (legacyeslintConfigin package.json) to v2 flat config.Changes
eslint-config-domdomegg^1.2.0→^2.0.9andeslint^8→^9.eslintConfigkey from package.json; add a flateslint.config.mjs.ignorePatterns: ["sample_configs"]→ a{ ignores: ["sample_configs/**"] }object before the preset spread."lint": "eslint".eslint --fix(spaces → tabs, brace-wrapped single-line ifs,type-only import modifiers, object-type separators). The large source diff is entirely mechanical — no logic changes.Three small fixes were needed to satisfy the stricter v2 ruleset (not suppressions):
cli.ts:errorPrefix + e→errorPrefix + String(e)(eisunknownin the catch).core.ts:code += language.value→String(language.value)(jsonc-parserNode.valueisany).fsGenerator.test.ts: parenthesize5 + (langs.length * 2)forno-mixed-operators.Status
npx eslintpasses; only a harmless "react package not installed" warning inherent to the shared preset).npm run build).🤖 Generated with Claude Code