Initial scaffolding#1
Open
dominicsayers wants to merge 13 commits into
Open
Conversation
dominicsayers
force-pushed
the
initial-scaffolding
branch
10 times, most recently
from
May 21, 2018 19:29
75b61b0 to
b3bc6ae
Compare
dominicsayers
force-pushed
the
initial-scaffolding
branch
3 times, most recently
from
June 18, 2018 14:41
d356c43 to
3960701
Compare
dominicsayers
force-pushed
the
initial-scaffolding
branch
5 times, most recently
from
July 17, 2018 23:08
b7a4619 to
802e943
Compare
dominicsayers
force-pushed
the
initial-scaffolding
branch
2 times, most recently
from
August 3, 2018 15:11
c166481 to
f23c92d
Compare
dominicsayers
force-pushed
the
initial-scaffolding
branch
10 times, most recently
from
August 11, 2018 19:18
84ccf1e to
2283838
Compare
dominicsayers
force-pushed
the
initial-scaffolding
branch
2 times, most recently
from
November 2, 2019 22:12
0c5f3f7 to
b874c41
Compare
dominicsayers
force-pushed
the
initial-scaffolding
branch
7 times, most recently
from
June 11, 2020 11:02
e74bdf9 to
f02209d
Compare
dominicsayers
force-pushed
the
initial-scaffolding
branch
2 times, most recently
from
June 11, 2020 11:33
16aea08 to
5ac01f1
Compare
Install Yarn as described here: [Install Yarn](https://yarnpkg.com/lang/en/docs/install) `rails new . -d postgresql --skip-test`
`bundle install` We won't be using these platforms so no need to cater for them.
dominicsayers
force-pushed
the
initial-scaffolding
branch
from
June 11, 2020 11:52
5ac01f1 to
2cf57e5
Compare
This is an opinionated configuration which you of course are at liberty to amend. Here are some of the reasons behind these choices: ``` Layout/LineLength: Max: 125 ``` I defer to Linus Torvalds: https://lkml.org/lkml/2020/5/29/1038 ``` Metrics/AbcSize: Exclude: - db/migrate/**/* ``` The generated migrations sometimes breach this limit. I see no sense in making people refactor generated code. ``` Metrics/BlockLength: Exclude: - spec/**/* ``` The structure of RSpec blocks makes this cop impossible to comply with for specs. ``` Metrics/MethodLength: Exclude: - db/migrate/**/* ``` This is also difficult to comply with for even the simplest and most orderly of specs. ``` Rails/FilePath: EnforcedStyle: arguments ``` Because `Rails.root` is a `Pathname`, say the wise people, you don't need to bother concatenating comma-separated arguments. `Pathname` does it all for you behind the scenes and you can go ahead and use forward slashes in safety and comfort. But I still don't like seeing the forward slashes. They *look* platform specific. ``` RSpec/ExampleLength: Max: 10 ``` Similar to `Metrics/MethodLength`, this is impossible to comply with in real life. ``` Style/Documentation: Enabled: false ``` Comments in code are just as likely to mislead as to illuminate. ``` Style/TrailingCommaInArrayLiteral: EnforcedStyleForMultiline: comma Style/TrailingCommaInArguments: EnforcedStyleForMultiline: comma Style/TrailingCommaInHashLiteral: EnforcedStyleForMultiline: comma ``` I know it's ugly. I know. But you'll thank me when you're reviewing code because the diffs are so much more logical.
`bundle install` `bin/spring binstub rspec && bin/rubocop -a` `bin/rails generate rspec:install && bin/rubocop -a`
dominicsayers
force-pushed
the
initial-scaffolding
branch
2 times, most recently
from
June 11, 2020 12:51
743ed5c to
f83f6cd
Compare
dominicsayers
force-pushed
the
initial-scaffolding
branch
2 times, most recently
from
June 27, 2020 13:55
f2f022f to
66bb97d
Compare
To create a new app from this template, just rename the module in `application.rb`
dominicsayers
force-pushed
the
initial-scaffolding
branch
from
June 27, 2020 13:58
66bb97d to
d520d01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.