Skip to content

add streamable http transport#7

Closed
robertlestak wants to merge 1 commit into
dominik1001:mainfrom
robertlestak:streamable-http
Closed

add streamable http transport#7
robertlestak wants to merge 1 commit into
dominik1001:mainfrom
robertlestak:streamable-http

Conversation

@robertlestak

Copy link
Copy Markdown

No description provided.

@dominik1001 dominik1001 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Some questions and remarks from my side.

Comment thread src/index.ts
})

async function main() {
console.error("CalDAV Config:", {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertlestak Did you intend to use console.error here?

Comment thread package.json
"dependencies": {
"@modelcontextprotocol/sdk": "^1.13.0",
"dotenv": "^16.5.0",
"express": "^4.21.2",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertlestak Do we really need full-blown express to add streamable http transport?

Comment thread Dockerfile
@@ -0,0 +1,14 @@
FROM node:20-alpine

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertlestak Could you explain in the README what the Dockerfile is for?

@dominik1001

Copy link
Copy Markdown
Owner

Closing this, because contributor didn't respond anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants