Fix attribute order dependency in ModelAttributesTest - #62909
Merged
Merged
Conversation
Signed-off-by: Medha Tiwari <medhavns1@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a test failure on Mono runtime by removing the dependency on attribute ordering in ModelAttributesTest.GetAttributesForParameter_SomeAttributes. The test was failing because it assumed SerializableAttribute would always be the first attribute returned by GetCustomAttributes(), but attribute order is not guaranteed by the C# specification.
Key Changes
- Replaced order-dependent
Assert.Collectionwith order-agnosticAssert.Containscheck - Updated test to verify presence of
SerializableAttributewithout assuming its position - Added explanatory comment about the order-agnostic nature of the check
captainsafia
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a test failure on Mono runtime by removing dependency on attribute ordering in ModelAttributesTest.GetAttributesForParameter_SomeAttributes
Description
The test was failing on Mono runtime because it assumed
SerializableAttributewould be the first attribute returned byGetCustomAttributes()see detail here
As pointed out by @jkotas in dotnet/runtime#117864:
The C# Specification confirms that attribute order is not guaranteed
This change ensures the test verifies the presence of the expected attribute without depending on its position, making it compliant with the C# specification and compatible across all .NET runtimes.
cc: @jkotas