Skip to content

Label all maestro PRs w/ area-infrastructure - #62146

Merged
wtgodbe merged 1 commit into
mainfrom
wtgodbe/AreaI
May 28, 2025
Merged

wtgodbe merged 1 commit into
mainfrom
wtgodbe/AreaI

Conversation

@wtgodbe

@wtgodbe wtgodbe commented May 28, 2025

Copy link
Copy Markdown
Member

This pull request includes a small change to the .github/policies/resourceManagement.yml file. The change removes the targetsBranch condition that specified the main branch as a target for applying the policy to apply the area-infrastructure label to dependency update PRs.

@wtgodbe
wtgodbe requested a review from Copilot May 28, 2025 19:14
@wtgodbe
wtgodbe requested a review from a team as a code owner May 28, 2025 19:14
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 28, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the resource management policy so that all dependency update PRs, regardless of branch, receive the area-infrastructure label.

  • Removed the targetsBranch: main condition from the policy
Comments suppressed due to low confidence (3)

.github/policies/resourceManagement.yml:242

  • After removing the targetsBranch entries, verify that the surrounding list indentation remains valid to avoid introducing an empty list item or YAML syntax errors.
then:

.github/policies/resourceManagement.yml:239

  • [nitpick] Consider adding a comment above this rule to note that it now applies to all branches, so future maintainers understand the broadened scope.
- titleContains:

.github/policies/resourceManagement.yml:240

  • Add or update automated tests to cover dependency update PRs on branches other than main to prevent regressions.
pattern: Source code updates

@wtgodbe

wtgodbe commented May 28, 2025

Copy link
Copy Markdown
Member Author

/ba-g Fabricbot update only

@danroth27 danroth27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wtgodbe
wtgodbe merged commit 05c5d65 into main May 28, 2025
@wtgodbe
wtgodbe deleted the wtgodbe/AreaI branch May 28, 2025 19:15
@wtgodbe wtgodbe changed the title label all maestro PRs w/ area-infrastructure Label all maestro PRs w/ area-infrastructure May 28, 2025
@dotnet-policy-service dotnet-policy-service Bot added this to the 10.0-preview6 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants