Skip to content

[release/10.0] Update OpenApi to 2.7.5 - #67464

Merged
wtgodbe merged 3 commits into
release/10.0from
dev/ygerges/update-openapi
Jul 6, 2026
Merged

wtgodbe merged 3 commits into
release/10.0from
dev/ygerges/update-openapi

Conversation

@Youssef1313

@Youssef1313 Youssef1313 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Closes #67505

Copilot AI review requested due to automatic review settings June 29, 2026 15:34
@Youssef1313
Youssef1313 requested review from a team and wtgodbe as code owners June 29, 2026 15:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Youssef1313 Youssef1313 added the tell-mode Indicates a PR which is being merged during tell-mode label Jun 29, 2026
@wtgodbe

wtgodbe commented Jun 29, 2026

Copy link
Copy Markdown
Member

Please port to main as well

@Youssef1313

Youssef1313 commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

@wtgodbe main is on latest 3.x already (#66998)

@Youssef1313

Copy link
Copy Markdown
Member Author

Well, there was a newer version released for 3.x only 3 weeks ago. Let me update to 3.7.0: #67468

@wtgodbe

wtgodbe commented Jun 29, 2026

Copy link
Copy Markdown
Member

Looks like there's a test failure in OpenApiDocumentIntegrationTests.VerifyOpenApiDocument(documentName: "schemas-by-ref", version: OpenApi3_0)

@Youssef1313

Copy link
Copy Markdown
Member Author

@copilot Update the test so that it passes.

@Youssef1313

Copy link
Copy Markdown
Member Author

It looks like Microsoft.OpenApi might have changed some behavior - hopefully it's fine as long as it's correct and compliant with the spec.

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot AI requested a review from a team as a code owner June 29, 2026 16:57

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@copilot Update the test so that it passes.

Updated the schemas-by-ref OpenAPI 3.0 snapshot in commit b158b60. The change reflects how OpenApi 2.7.5 serializes nullable schemas differently — nullable: true and the type are now emitted at the parent allOf level rather than as a separate sibling schema inside the allOf array. All 14 VerifyOpenApiDocument tests now pass.

@wtgodbe

wtgodbe commented Jun 29, 2026

Copy link
Copy Markdown
Member

/home/vsts/work/1/s/src/Components/test/E2ETest/ServerExecutionTests/ServerReconnectionWithoutStateTest.cs(14,28): error CS0234: The type or namespace name 'Communication' does not exist in the namespace 'OpenQA.Selenium.BiDi' (are you missing an assembly reference?) [/home/vsts/work/1/s/src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj]
/home/vsts/work/1/s/src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs(12,28): error CS0234: The type or namespace name 'Communication' does not exist in the namespace 'OpenQA.Selenium.BiDi' (are you missing an assembly reference?) [/home/vsts/work/1/s/src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj]

@copilot please fix

Co-authored-by: wtgodbe <14283640+wtgodbe@users.noreply.github.com>
Copilot AI requested a review from a team as a code owner June 29, 2026 22:14

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

/home/vsts/work/1/s/src/Components/test/E2ETest/ServerExecutionTests/ServerReconnectionWithoutStateTest.cs(14,28): error CS0234: The type or namespace name 'Communication' does not exist in the name...

Fixed in the latest commit. The OpenQA.Selenium.BiDi.Communication namespace was removed in Selenium 4.44.0 (which this repo uses). The using directive in both files was unused — no types from that namespace were actually referenced in either file — so removing it is sufficient.

@Youssef1313

Copy link
Copy Markdown
Member Author

@wtgodbe The failures here appear to be flaky tests that were previously disabled in release/8.0 and release/9.0 (e.g #67243)

Can we quarantine the failures, or otherwise ba-g and merge as-is?

@wtgodbe

wtgodbe commented Jul 6, 2026

Copy link
Copy Markdown
Member

Can we quarantine the failures

Let's do that in a follow-up - mind opening a PR for that?

@wtgodbe

wtgodbe commented Jul 6, 2026

Copy link
Copy Markdown
Member

/ba-g failures are known flakiness

@wtgodbe
wtgodbe merged commit 99e2abc into release/10.0 Jul 6, 2026
27 of 28 checks passed
@wtgodbe
wtgodbe deleted the dev/ygerges/update-openapi branch July 6, 2026 16:30
@adamhoskins123

Copy link
Copy Markdown

Hi @wtgodbe is this change likely to be in July or August release? Apologies not sure where I would need to look to find this info.

@wtgodbe

wtgodbe commented Jul 8, 2026

Copy link
Copy Markdown
Member

is this change likely to be in July or August release?

This will ship in the August release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API

5 participants