fix(styles): persist and display custom style previews#153
Merged
Conversation
Handanhhhy
marked this pull request as ready for review
July 20, 2026 08:17
Signed-off-by: handan <handanhhhy@gmail.com>
Handanhhhy
force-pushed
the
feature/issue-152-style-upload-preview
branch
from
July 20, 2026 08:27
28a2129 to
d9f2e32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The upload flow treated an HTTP 200 error envelope as success and continued into analysis/style creation without a valid preview path. Custom style metadata also had no persisted preview path, and generated media URLs used the resolved project name instead of the requested project ID, causing 404 responses in the UI.
User impact
Preset previews remain bundled and read-only. User-uploaded custom style images are stored under the project, survive reloads, and appear in both the style list and detail panel as soon as upload succeeds; AI analysis remains a separate follow-up state.
Verification
uv run pytest tests/test_api_styles.py -q— 17 passeduv run ruff check src/novelvideo/api/routes/styles.py src/novelvideo/services/style_service.py tests/test_api_styles.pypnpm exec vitest run src/__tests__/routes/styles.ce.test.tsx— 4 passedpnpm build200 image/pngCloses #152