Repository navigation
fix(ci): build llama-helper sidecar before Rust tests in PR Checks - #17
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The Rust job runs cargo test in frontend/src-tauri, which triggers Tauri's build script. tauri.conf.json requires the llama-helper sidecar at binaries/llama-helper-x86_64-unknown-linux-gnu, but PR Checks did not build it (unlike build-linux.yml and other release workflows). Add a pre-test step to build and copy the sidecar binary, matching the existing Linux build workflow. Co-authored-by: Drew <drewsepeczi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the PR Checks workflow failure on
main(run 32168196009, commit969c3ca).The Rust (test) job failed at the Run Rust tests step (
cargo testinfrontend/src-tauri) because Tauri's build script requires thellama-helpersidecar atbinaries/llama-helper-x86_64-unknown-linux-gnu, which was not present.Other Linux workflows (e.g.
build-linux.yml) already build and copy this binary before compiling the Tauri app. PR Checks was missing that step.This PR adds a Build llama-helper sidecar step before
cargo test, matching the existing Linux build workflow.Related Issue
Triggered by failed workflow run on
mainat969c3ca7c847f69036a34ccba3d4ffae77a5c942.Type of Change
Testing
Verified the failing command and root cause from CI logs. Local full
cargo testwas not run in the cloud agent environment (git dependency resolution issue unrelated to this change); CI should validate on merge.Verification command (matches CI Rust job):
Documentation
Checklist
Additional Notes
Classification: Test/CI configuration only (
.github/workflows/pr-ci.yml).Other failures on the same SHA: Multiple Dependabot Updates runs also failed (
@blocknote/reactunknown_error). Those are separate from PR Checks and were not addressed in this PR.