chore: Explicitly list files to collect coverage from #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
- Coverage 99.78% 97.89% -1.89%
==========================================
Files 77 77
Lines 1879 1903 +24
Branches 251 254 +3
==========================================
- Hits 1875 1863 -12
- Misses 4 40 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jun 20, 2025
By default, files not loaded from any test will not effect coverage metrics, although actually we want them to be counted as uncovered.
13a1326 to
8573695
Compare
This was referenced Jun 23, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
By default jest will only track coverage stats for files imported by a test. What about files that are never imported by any test? They aren't included in the report. But it would be better to include them and mark them as having 0% coverage.
Test Plan
Codecov in CI will show a difference in the results.
e: It looks like it adds two untested source files to coverage, and removes two test files from it.