chore: Use 'v8' coverage provider #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 97.89% 97.39% -0.51%
==========================================
Files 77 87 +10
Lines 1903 11889 +9986
Branches 254 554 +300
==========================================
+ Hits 1863 11579 +9716
- Misses 40 303 +263
- Partials 0 7 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
13a1326 to
8573695
Compare
9a898bf to
174d088
Compare
wschurman
approved these changes
Jun 21, 2025
Member
wschurman
left a comment
There was a problem hiding this comment.
Let's ignore the barrel files (src/index.ts) files since there's nothing really to test. Otherwise this looks good.
174d088 to
dd7f926
Compare
8573695 to
64057b6
Compare
45e17f6 to
5d61e92
Compare
5d61e92 to
88dc7f5
Compare
This was referenced Jun 23, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I was hoping this would be more accurate and consistent.
Test Plan
Codecov report from CI.
It looks like there are a few small changes here and there, and then the
src/index.tsfiles were all added to coverage and marked as uncovered.