Repository navigation
fix(engine): increase build timeout duration, add batch uri reindex with debounce - #698
Merged
Merged
Conversation
doorgan
reviewed
Jun 1, 2026
doorgan
left a comment
Contributor
There was a problem hiding this comment.
Thank you! I left you some comments, there's also some failing tests that need fixing
| end | ||
|
|
||
| start_supervised!({Reindex, reindex_fun: reindex_fun}) | ||
| start_supervised!({Reindex, reindex_fun: reindex_fun, debounce_interval_millis: 0}) |
Contributor
There was a problem hiding this comment.
Can we add some tests that set a non-zero debounce interval, and check that the debounce is working? 100 or 500ms should work
Contributor
Author
|
Thanks for the feedback! I’ll push the fixes shortly. Is it possible to run all tests locally, so I could be sure that CI passes? |
Contributor
|
@lsdrfrx yes you can run |
doorgan
force-pushed
the
debounce-compilation
branch
from
June 18, 2026 14:48
c6cf41c to
85a23b9
Compare
doorgan
approved these changes
Jun 18, 2026
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin v0.1
git worktree add -d .worktree/backport-698-to-v0.1 origin/v0.1
cd .worktree/backport-698-to-v0.1
git switch --create backport-698-to-v0.1
git cherry-pick -x ba07dcd442fc18a6e60d3ba6e45ceed55b3611e5 |
doorgan
added a commit
that referenced
this pull request
Jun 18, 2026
…ith debounce (#698) - Increased `Engine.Build` compilation timeout from 50ms to 1000ms (do not know which value will fit) - Slightly reworked `Engine.Commands.Reindex`: now reindex adds URIs into `pending_uris` MapSet and process them after 1000ms debounce Closes #672 --------- Co-authored-by: doorgan <dorgandash@gmail.com> (cherry picked from commit ba07dcd)
doorgan
added a commit
that referenced
this pull request
Jun 24, 2026
…ith debounce (#698) - Increased `Engine.Build` compilation timeout from 50ms to 1000ms (do not know which value will fit) - Slightly reworked `Engine.Commands.Reindex`: now reindex adds URIs into `pending_uris` MapSet and process them after 1000ms debounce Closes #672 --------- Co-authored-by: doorgan <dorgandash@gmail.com>
doorgan
pushed a commit
that referenced
this pull request
Jul 9, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.6](v0.1.5...v0.1.6) (2026-07-09) ### Features * allow setting Elixir source directory ([#776](#776)) ([cd91d54](cd91d54)) * bring back remote shell ([#775](#775)) ([b4ac3bb](b4ac3bb)) ### Bug Fixes * **engine:** increase build timeout duration, add batch uri reindex with debounce ([#733](#733)) ([72a2f9e](72a2f9e)), closes [#698](#698) * **engine:** set target when evaluating config diagnostics ([#735](#735)) ([b447094](b447094)) * **expert:** extend list of editors having VSCode completion bug ([#738](#738)) ([83d2ffd](83d2ffd)), closes [#736](#736) * **forge:** monitor beam rewriting worker process ([#741](#741)) ([fefc5c7](fefc5c7)) * port Refactorex into Forge ([#747](#747)) ([#754](#754)) ([131d642](131d642)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increased
Engine.Buildcompilation timeout from 50ms to 1000ms (do not know which value will fit)Slightly reworked
Engine.Commands.Reindex: now reindex adds URIs intopending_urisMapSet and process them after 1000ms debounceCloses #672