Skip to content

Bugfix/documentation #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 27, 2025
Merged

Bugfix/documentation #69

merged 16 commits into from
Oct 27, 2025

Conversation

@akoerner1
Copy link
Contributor

@akoerner1 akoerner1 commented Oct 24, 2025 •
edited
Loading

Description

This PR includes a few minor bug fixes, features and documentation updates detailed below.

Bugfixes

Foxglove bugfix

This addresses Major Bugfix #2 in the following PR: #65
This was not completely address and there were some documentation links that were not updated.

Documentation dead links

This PR cleans up and fixes some dead links in the documentation

Removed pip and apt caching via Docker Buildx

APT and PIP package caching causes significant build issues and has been removed.

The following is one example of a non-deterministic faulre that is cuased by docker buildx caching of apt:

17.01 Get:19 http://security.ubuntu.com/ubuntu noble-security/multiverse amd64 Packages [33.1 kB]                                                                            
24.54 Get:20 http://archive.ubuntu.com/ubuntu noble-updates/universe amd64 Packages [1937 kB]                                                                                
24.66 Get:21 http://archive.ubuntu.com/ubuntu noble-updates/restricted amd64 Packages [2744 kB]                                                                              
24.86 Get:22 http://archive.ubuntu.com/ubuntu noble-updates/multiverse amd64 Packages [35.9 kB]                                                                              
24.86 Get:23 http://archive.ubuntu.com/ubuntu noble-backports/main amd64 Packages [49.4 kB]                                                                                  
24.87 Get:24 http://archive.ubuntu.com/ubuntu noble-backports amd64 Contents (deb) [782 kB]                                                                                  
24.93 Get:25 http://archive.ubuntu.com/ubuntu noble-backports/universe amd64 Packages [33.9 kB]                                                                              
30.07 Using cached package lists                                                                                                                                             
30.09 Reading package lists...                                                                                                                                               
30.12 Building dependency tree...                                                                                                                                            
30.12 Reading state information...                                                    
30.13 Package gdbserver is not available, but is referred to by another package.                                                                                             
30.13 This may mean that the package is missing, has been obsoleted, or                                                                                                      
30.13 is only available from another source                                           
30.13                                                                                 
30.13 E: Unable to locate package ros-jazzy-ros-base                                                                                                                         
30.13 E: Unable to locate package ros-jazzy-foxglove-bridge                                                                                                                  
30.13 E: Unable to locate package ros-jazzy-plotjuggler-ros                                                                                                                  
30.13 E: Unable to locate package ros-jazzy-plotjuggler                                                                                                                      
30.13 E: Unable to locate package ros-jazzy-rosbridge-suite                                                                                                                  
30.13 E: Unable to locate package telnet

Features

Adore cli core hash change

removed the parent repo hash/branch name from the adore cli core image. This should improve docker registry cache hits and significantly reduce build times across branches.

ADORe ros2 msgs packaging and release

added a make target to the ros2_workspace makefile. This target generates a .deb archive for adore_ros2_msgs.
This target is then used in the github workflow to publish a deb archive of adore_ros2_msgs

Moved documentation lint call to earlier in the ci pipeline

It is annoying to have the ci pipeline fail due to a spelling error late in the game. This moves the documentation lint call
sooner in the github action to fail early.

Added "make package_adore_ros2_msgs" target to generate .deb package for adore_ros2_msgs

Also added release step to include package in binary release.

@akoerner1
added/updated simulation_helpers/visualizer.py to address foxglove-br…
96e4d33 
…idge plugin and updated documentation to point to the new foxglove link, updated documentaiton to fix dead links

Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
updated adore cli to exclude parent branch/hash name from core image …
ca65db0 
…to improve image cache hits, removed gate on pushing adore cli core image during accepted merger. now all PRs will generate a core image in the github repo registry

Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
updated ros2_workspace makefile to include make package_adore_ros2_ms…
7607ea4 
…gs to generate deb archive for adore_ros2_msgs, added adore_ros2_msgs to release artificats in the github action for releases

Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1 akoerner1 requested a review from n-mat October 24, 2025 11:40
@akoerner1
added websocket and rosbridge to aspell dictionary
3c55156 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
merged develop in to bugfix branch
8743398 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
fixed merge conflict
c366fff 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
stripped/removed apt and pip docker buildx caching due to the build f…
bd73fa6 
…ailures it was causing

Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
added package_adore_ros2_msgs target
81a4e1e 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
updated workflow to include image push for lichtblick
8367d7b 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
fixed github repo url for core image
c8097dc 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
reordered workflow and change upload debian package step pattern
a5ab7d9 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
updated try_pull_base and try_pull_core or the adore cli
635a8d2 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
updated workflow to include pulling base images
9fe2ceb 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
parameterized repo urls
00f0543 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
updated git url for adore_cli
020c6d7 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@akoerner1
updated git url for adore_cli
0986ab5 
Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
@n-mat n-mat merged commit e2821e0 into develop Oct 27, 2025
8 checks passed
@n-mat n-mat deleted the bugfix/documentation branch October 27, 2025 10:12
akoerner1 added a commit that referenced this pull request Oct 27, 2025
@akoerner1
Updated documentation for PR 69: #69
f611553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n-mat n-mat n-mat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akoerner1 @n-mat