Bugfix/docs publish #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoerner1
added a commit
that referenced
this pull request
Jan 7, 2025
Merged
n-mat
pushed a commit
that referenced
this pull request
Oct 27, 2025
# Description This PR includes a few minor bug fixes, features and documentation updates detailed below. ## Bugfixes ### Foxglove bugfix This addresses Major Bugfix #2 in the following PR: #65 This was not completely address and there were some documentation links that were not updated. ### Documentation dead links This PR cleans up and fixes some dead links in the documentation ### Removed pip and apt caching via Docker Buildx APT and PIP package caching causes significant build issues and has been removed. The following is one example of a non-deterministic faulre that is cuased by docker buildx caching of apt: ``` 17.01 Get:19 http://security.ubuntu.com/ubuntu noble-security/multiverse amd64 Packages [33.1 kB] 24.54 Get:20 http://archive.ubuntu.com/ubuntu noble-updates/universe amd64 Packages [1937 kB] 24.66 Get:21 http://archive.ubuntu.com/ubuntu noble-updates/restricted amd64 Packages [2744 kB] 24.86 Get:22 http://archive.ubuntu.com/ubuntu noble-updates/multiverse amd64 Packages [35.9 kB] 24.86 Get:23 http://archive.ubuntu.com/ubuntu noble-backports/main amd64 Packages [49.4 kB] 24.87 Get:24 http://archive.ubuntu.com/ubuntu noble-backports amd64 Contents (deb) [782 kB] 24.93 Get:25 http://archive.ubuntu.com/ubuntu noble-backports/universe amd64 Packages [33.9 kB] 30.07 Using cached package lists 30.09 Reading package lists... 30.12 Building dependency tree... 30.12 Reading state information... 30.13 Package gdbserver is not available, but is referred to by another package. 30.13 This may mean that the package is missing, has been obsoleted, or 30.13 is only available from another source 30.13 30.13 E: Unable to locate package ros-jazzy-ros-base 30.13 E: Unable to locate package ros-jazzy-foxglove-bridge 30.13 E: Unable to locate package ros-jazzy-plotjuggler-ros 30.13 E: Unable to locate package ros-jazzy-plotjuggler 30.13 E: Unable to locate package ros-jazzy-rosbridge-suite 30.13 E: Unable to locate package telnet ``` ## Features ### Adore cli core hash change removed the parent repo hash/branch name from the adore cli core image. This should improve docker registry cache hits and significantly reduce build times across branches. ### ADORe ros2 msgs packaging and release added a make target to the ros2_workspace makefile. This target generates a .deb archive for adore_ros2_msgs. This target is then used in the github workflow to publish a deb archive of adore_ros2_msgs ### Moved documentation lint call to earlier in the ci pipeline It is annoying to have the ci pipeline fail due to a spelling error late in the game. This moves the documentation lint call sooner in the github action to fail early. ### Added "make package_adore_ros2_msgs" target to generate .deb package for `adore_ros2_msgs` Also added release step to include package in binary release. --------- Signed-off-by: Andrew Koerner <andrew.koerner@dlr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified the documentation/publish.env file to reference the master branch instead of the develop branch.
With "make publish" from the documentation folder, documentation from the
remotes/origin/masterwill be published to theremotes/origin/gh-pagesand will be available viahttps://<username/organization>.github.io/adore/e.g., https://dlr-ts.github.io/adore/