Skip to content

Replace Boost.spirit #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marcosbento wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Replace Boost.spirit #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
efdf54e
Add V1 vs V2 differential test harness
marcosbento Jul 25, 2026
3198ad9
Rename & namespace V1 parser
marcosbento Jul 25, 2026
aef54df
Add V2 parser skeleton and wire V1/V2 test harness
marcosbento Jul 25, 2026
3cc0416
Implement handcrafted V2 expression parser
marcosbento Jul 25, 2026
4164171
Add checkpoint parser performance benchmark
marcosbento Jul 25, 2026
90850aa
Switch production expression parser to V2
marcosbento Jul 25, 2026
9a00a6b
Rename v1/v2 expression tests, add Defs::check benchmark
marcosbento Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,8 @@ set(srcs
node/src/ecflow/node/ExprAstVisitor.hpp
node/src/ecflow/node/ExprDuplicate.hpp
node/src/ecflow/node/ExprParser.hpp
node/src/ecflow/node/ExprParserV1.hpp
node/src/ecflow/node/ExprParserV2.hpp
node/src/ecflow/node/Expression.hpp
node/src/ecflow/node/Family.hpp
node/src/ecflow/node/Flag.hpp
Expand Down Expand Up @@ -397,6 +399,7 @@ set(srcs
node/src/ecflow/node/ResolveExternsVisitor.hpp
node/src/ecflow/node/ServerState.hpp
node/src/ecflow/node/Signal.hpp
node/src/ecflow/node/SimpleExprParser.hpp
node/src/ecflow/node/Submittable.hpp
node/src/ecflow/node/Suite.hpp
node/src/ecflow/node/SuiteChanged.hpp
Expand Down Expand Up @@ -454,7 +457,8 @@ set(srcs
node/src/ecflow/node/ExprAst.cpp
node/src/ecflow/node/ExprAstVisitor.cpp
node/src/ecflow/node/ExprDuplicate.cpp
node/src/ecflow/node/ExprParser.cpp
node/src/ecflow/node/ExprParserV1.cpp
node/src/ecflow/node/ExprParserV2.cpp
node/src/ecflow/node/Expression.cpp
node/src/ecflow/node/Family.cpp
node/src/ecflow/node/Flag.cpp
Expand Down Expand Up @@ -483,6 +487,7 @@ set(srcs
node/src/ecflow/node/ResolveExternsVisitor.cpp
node/src/ecflow/node/ServerState.cpp
node/src/ecflow/node/Signal.cpp
node/src/ecflow/node/SimpleExprParser.cpp
node/src/ecflow/node/Submittable.cpp
node/src/ecflow/node/Suite.cpp
node/src/ecflow/node/SuiteChanged.cpp
Expand Down
57 changes: 57 additions & 0 deletions libs/node/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,28 @@ ecflow_add_test(
)


ecbuild_add_test(
TARGET
u_expressions_parser
LABELS
unit nightly fast
SOURCES
# Sources
test/expressions/TestExpressionsParser.cpp
test/expressions/TestExpressionsParser_main.cpp # test entry point
LIBS
ecflow_all
test_scaffold
nlohmann::json
Boost::boost # Boost header-only libraries must be available (namely unit_test_framework)
TEST_DEPENDS
u_node
)
target_clangformat(u_expressions_parser
CONDITION ENABLE_TESTS
)


if (ENABLE_ALL_TESTS)
set(test_srcs
test/TestSingleExprParse.cpp
Expand All @@ -164,6 +186,41 @@ if (ENABLE_ALL_TESTS)
)


ecbuild_add_test(
TARGET
p_expressions_parser_benchmark
LABELS
performance
ARGS
--data-dir ${CMAKE_CURRENT_SOURCE_DIR}/test/expressions/data/scratch/checkpoints
SOURCES
test/expressions/ExpressionsParserBenchmark.cpp
LIBS
ecflow_all
nlohmann::json
)
target_clangformat(p_expressions_parser_benchmark
CONDITION ENABLE_TESTS
)

ecbuild_add_test(
TARGET
p_defs_check_benchmark
LABELS
performance
ARGS
--data-dir ${CMAKE_CURRENT_SOURCE_DIR}/test/expressions/data/scratch/checkpoints
SOURCES
test/expressions/DefsCheckBenchmark.cpp
LIBS
ecflow_all
nlohmann::json
)
target_clangformat(p_defs_check_benchmark
CONDITION ENABLE_TESTS
)


set(test_srcs
# Headers
test/parser/PersistHelper.hpp
Expand Down
Loading
Loading