Skip to content

ci: RelWithDebInfo, CMake presets and the shared HPC base template - #342

Merged
iainrussell merged 10 commits into
developfrom
sync-branch/update-cmake-build-type
Sep 22, 2026
Merged

iainrussell merged 10 commits into
developfrom
sync-branch/update-cmake-build-type

Conversation

@mcocdawc

@mcocdawc mcocdawc commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Description

  • Build type ReleaseRelWithDebInfo.
  • New CMakePresets.json with a ci preset (ENABLE_TESTS, ENABLE_AEC, ENABLE_ECKIT_SQL, ENABLE_ECKIT_CMD) used by both the GitHub action and the HPC recipe. The runner lane now builds with AEC too, as HPC already did.
  • .ci/hpc/build.sh.j2 extends the shared base template, keeping only the bison/flex preflight; the leg keeps time = "00:40:00".

Needs ecmwf/ci-infrastructure#63 on main first. Part of the coordinated sync-branch/update-cmake-build-type change across ecbuild, stack-dependencies, eckit, eccodes and ecflow.

🤖 Generated with Claude Code

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/eckit/pull-requests/PR-342

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.77%. Comparing base (4e3fbfb) to head (c1e0336).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #342      +/-   ##
===========================================
- Coverage    67.79%   67.77%   -0.02%     
===========================================
  Files         1183     1183              
  Lines        62158    62158              
  Branches      4690     4690              
===========================================
- Hits         42138    42130       -8     
- Misses       20020    20028       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcocdawc mcocdawc added the run-downstream-CI Run the downstream fan-out for this PR label Sep 18, 2026
@mcocdawc mcocdawc added downstream-CI-not-needed Deliberately skip the downstream fan-out and removed run-downstream-CI Run the downstream fan-out for this PR labels Sep 18, 2026
@mcocdawc

Copy link
Copy Markdown
Contributor Author

I don't run the downstream CI here, because it is already run as part of the synchronised PR from stack-dependencies

mcocdawc and others added 6 commits September 18, 2026 16:19
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@mcocdawc
mcocdawc requested a review from joobog September 22, 2026 09:24

@joobog joobog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!!!

@iainrussell
iainrussell merged commit d958c46 into develop Sep 22, 2026
243 of 250 checks passed
@iainrussell
iainrussell deleted the sync-branch/update-cmake-build-type branch September 22, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

downstream-CI-not-needed Deliberately skip the downstream fan-out

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants