CI cache by pca006132 · Pull Request #1574 · elalish/manifold

pca006132 · 2026-03-07T09:36:11Z

No description provided.

codecov · 2026-03-07T10:52:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (91d700b) to head (bec839c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
+ Coverage   92.59%   95.16%   +2.57%     
==========================================
  Files          33       34       +1     
  Lines        6048     7659    +1611     
==========================================
+ Hits         5600     7289    +1689     
+ Misses        448      370      -78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Updates CI to reduce network fetches and speed up builds by caching external dependencies and using them as FetchContent sources across jobs.

Changes:

Add a reusable composite action to clone + cache external git dependencies (TBB, Clipper2, nanobind, fuzztest).
Refactor .github/workflows/manifold.yml to use cached clones, add more caching (pip, apt, nix), and reorganize/expand job coverage (incl. Windows).
Update the CMake subdirectory consumer test script to pass FETCHCONTENT_SOURCE_DIR_* overrides.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`scripts/test-cmake-subdir.sh`	Passes cached dependency paths into the subdir consumer build via `FETCHCONTENT_SOURCE_DIR_*`.
`.github/workflows/manifold.yml`	Major CI refactor: caching, dependency cloning reuse, Windows job, updated build/test invocations, nix cache.
`.github/actions/git-clone/action.yml`	New composite action implementing clone + actions/cache for external repos.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

pca006132 · 2026-03-16T16:08:11Z

 mkdir build
 cd build
-cmake ..
+cmake -DFETCHCONTENT_SOURCE_DIR_CLIPPER2=$CLIPPER2 -DFETCHCONTENT_SOURCE_DIR_TBB=$TBB ..


only add these when the variables are non-empty.

pca006132 · 2026-03-16T16:06:58Z

+    - name: Test
+      if: matrix.cross_section == 'ON'
      run: |
+        ./build/test/manifold_test
+        # python tests
        export PYTHONPATH=$PYTHONPATH:$(pwd)/build/bindings/python
        python3 bindings/python/examples/run_all.py -e
        python3 -m pytest


We don't need to run tests with cross-section disabled, since it can only disable tests instead of testing more code path. It is a strictly compile-only check CI check.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

elalish

There's a lot here - do you have a general description of what's changing at a high level?

elalish · 2026-03-16T19:50:48Z

+      with:
+        name: tbb
+        url: https://github.com/oneapi-src/oneTBB.git
+        rev: f1862f38f83568d96e814e469ab61f88336cc595


Can we use tagged releases for any of these?

I did not find a way to do a shallow pull with tagged releases previously. I can probably ask LLM to see if there is a way.

elalish · 2026-03-16T19:52:42Z

-    - uses: jwlawson/actions-setup-cmake@v2
+    - uses: actions/setup-node@v6
+      with:
+        node-version: 24


I think I used 25 somewhere else. Should probably be consistent.

Just checked, you are using 25 for publish_npm, will change this to 25.

elalish · 2026-03-16T19:53:26Z

-        cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DMANIFOLD_STRICT=ON -DMANIFOLD_DEBUG=ON -DMANIFOLD_FUZZ=ON -DMANIFOLD_PYBIND=OFF -DCMAKE_CXX_COMPILER=clang++ ..
-        make
-
-  build_fuzzer_mac:


Are there some CI runs that I need to remove from the github required list?

Some of the names have been changed. E.g., build_fuzzer_mac and build_fuzzer become build_fuzzer with an os matrix.

You need to change the required list to merge this.

pca006132 · 2026-03-17T06:01:56Z

There's a lot here - do you have a general description of what's changing at a high level?

Will do later today, busy with other stuff for now.

pca006132 · 2026-03-17T07:36:12Z

The copilot summary above was quite good, but I can expand on that.

This now caches built-in dependencies like tbb, clipper2, googletest, and nanobind. So we are not pulling them from GitHub for every CI job. This one is a self-written GitHub action script. I haven't found a good way to do shallow clones with release tags, so sha256 ids are used for now.
This caches npm, pip, emsdk, and apt installs using GitHub Actions.
Uses YML anchors and references to deduplicate steps like pulling in tbb dependency.
Reorganize actions a bit.
Use one job for fuzzer builds, and use matrix for testing different OSes.
For Linux builds, skip tests for MANIFOLD_CROSS_SECTION=OFF, since we only need to check if it compiles. The option should not affect code paths.
Rewrite stuff a bit to avoid cd. Not a big deal.

Not yet solved:

CMake install cache on Windows. Maybe we can use a Chocolatey action for that.
Homebrew install cache on macOS. There are GitHub Actions for this, but there are not that many stars, so should review before using that.
Should gather code coverage for parallel build, but it is too slow for now to be run in the CI.

elalish

Thanks - I didn't even notice copilot summarized the PR; that's an interesting feature.

pca006132 changed the title ~~Ci cache~~ CI cache Mar 7, 2026

pca006132 force-pushed the ci-cache branch from 6c7d4d9 to eb14825 Compare March 7, 2026 09:37

pca006132 force-pushed the ci-cache branch 2 times, most recently from f1cfcb5 to c154426 Compare March 7, 2026 17:42

pca006132 mentioned this pull request Mar 8, 2026

Fix actions-setup-cmake #1570

Closed

pca006132 force-pushed the ci-cache branch from 12318c9 to 1723e33 Compare March 16, 2026 15:55

pca006132 added 18 commits March 16, 2026 23:56

better caching for CI

2446932

fix

8aee897

fix 2

80ec133

fix 3

bbf79c7

fix 4

f791e5c

fix

610764c

.

f4abadd

.

4ff9fa8

.

43adf4d

.

89f28be

updates

9cf4ff2

update

e103eba

.

2356bf3

fix

dc35e9f

fix

8812785

fix windows

d5ec0df

fix typo

a98eb0f

fix

c20e9e4

pca006132 force-pushed the ci-cache branch from 1723e33 to c20e9e4 Compare March 16, 2026 15:56

pca006132 requested a review from Copilot March 16, 2026 15:57

pca006132 marked this pull request as ready for review March 16, 2026 15:57

Copilot started reviewing on behalf of pca006132 March 16, 2026 15:58 View session

pca006132 mentioned this pull request Mar 16, 2026

ci: add cross-platform determinism check (Part 1) #1594

Merged

Copilot AI reviewed Mar 16, 2026

View reviewed changes

pca006132 and others added 4 commits March 17, 2026 00:04

disable parallelized build for codecov

596935e

Apply suggestions from code review

3dac813

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

update test-cmake

5ed6ba7

avoid testing cmake consumer on windows

1265ce5

elalish approved these changes Mar 16, 2026

View reviewed changes

pca006132 added 2 commits March 17, 2026 15:55

address comments

0f8d8a2

fix googletest

bec839c

elalish approved these changes Mar 17, 2026

View reviewed changes

elalish merged commit f3d121b into master Mar 17, 2026
36 checks passed

elalish deleted the ci-cache branch March 17, 2026 09:59

pca006132 mentioned this pull request Mar 22, 2026

v3.4.1 #1605

Merged

Conversation

pca006132 commented Mar 7, 2026

Uh oh!

codecov Bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elalish left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pca006132 Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pca006132 commented Mar 17, 2026

Uh oh!

pca006132 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elalish left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Mar 7, 2026 •

edited

Loading

pca006132 Mar 17, 2026 •

edited

Loading

pca006132 commented Mar 17, 2026 •

edited

Loading