Skip to content

v3.4.1#1605

Merged
pca006132 merged 1 commit into
masterfrom
v3.4.1
Mar 24, 2026
Merged

v3.4.1#1605
pca006132 merged 1 commit into
masterfrom
v3.4.1

Conversation

@pca006132

@pca006132 pca006132 commented Mar 22, 2026

Copy link
Copy Markdown
Collaborator

This version reverts the lazy collider change (which causes numerical issues in some cases), fixes npm publish failure, fixes some minor bugs and improves ManifoldCAD.

Notable Bug Fixes

ManifoldCAD Updates

Documentation Changes

Miscellaneous

New Contributors

@pca006132 pca006132 marked this pull request as ready for review March 22, 2026 13:24
@pca006132

Copy link
Copy Markdown
Collaborator Author

@elalish I'm thinking if we should still put ManifoldCAD stuff in the release notes, since that is not really part of the release?

@codecov

codecov Bot commented Mar 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (98c317f) to head (aba3ac0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files          34       34           
  Lines        7659     7659           
=======================================
  Hits         7289     7289           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elalish elalish left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. As for ManifoldCAD - well, it's in the monorepo, and if it's not in these notes, where would it be? I suppose we could have a little "what's new" pop-up when the service worker gets a new version (once we restrict it to published release versions), but until then it can stay here.

@pca006132 pca006132 merged commit 31afd71 into master Mar 24, 2026
36 checks passed
@pca006132 pca006132 deleted the v3.4.1 branch March 24, 2026 05:40
@elalish

elalish commented Mar 24, 2026

Copy link
Copy Markdown
Owner

Weird, looks like our npm publish action is still failing: https://github.com/elalish/manifold/actions/runs/23474959650/job/68305685392

Oddly it says it's trying to publish 3.4.0 instead of 3.4.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants