Repository navigation
Add support for OkHttp 4.4+ - #1672
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
| import java.util.List; | ||
|
|
||
| @RunWith(Parameterized.class) | ||
| public class OkHttp3ClientVersionIT { |
There was a problem hiding this comment.
[minor] maybe remove the 3 in the class name as we only test version 4.x
There was a problem hiding this comment.
It's named that way as it tests the com.squareup.okhttp3 module. I've added some versions from the 3.x version line.
| return Arrays.asList(new Object[][]{ | ||
| // ivy can't automatically resolve the dependencies, so we'll have to manually type them in | ||
| // check https://mvnrepository.com/artifact/com.squareup.okhttp3/okhttp for the respective versions of kotlin and okio | ||
| {List.of("com.squareup.okhttp3:okhttp:4.3.0", "org.jetbrains.kotlin:kotlin-stdlib:1.3.61", "com.squareup.okio:okio:2.4.1")}, |
There was a problem hiding this comment.
why not have a 1.x and 2.x versions in this list also ? I know that earlier version might not depend on Kotlin, thus we could expect them to be quite different code-wise.
There was a problem hiding this comment.
These are tested in OkHttpClientInstrumentationTest.java (not OkHttp3)
What does this PR do?
closes #1609
Checklist
Added an API method or config option? Document in which version this will be introduced