Skip to content

Added support for dropping fast exit spans - #2491

Merged
jackshirazi merged 9 commits into
elastic:mainfrom
tobiasstadler:fix-2083
Mar 9, 2022
Merged

jackshirazi merged 9 commits into
elastic:mainfrom
tobiasstadler:fix-2083

Conversation

@tobiasstadler

@tobiasstadler tobiasstadler commented Mar 3, 2022 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #2083

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation

@github-actions github-actions Bot added agent-java community Issues and PRs created by the community triage labels Mar 3, 2022
@github-actions

github-actions Bot commented Mar 3, 2022

Copy link
Copy Markdown

👋 @tobiasstadler Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

tobiasstadler added a commit to tobiasstadler/apm-agent-java that referenced this pull request Mar 3, 2022
@ghost

ghost commented Mar 3, 2022 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-09T14:46:46.450+0000

  • Duration: 47 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 2749
Skipped 16
Total 2765

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Comment thread CHANGELOG.asciidoc
tobiasstadler added a commit to tobiasstadler/apm-agent-java that referenced this pull request Mar 4, 2022
…n/SpanConfiguration.java

Co-authored-by: jackshirazi <jacks@fasterj.com>
Comment thread apm-agent-core/src/main/java/co/elastic/apm/agent/impl/ElasticApmTracer.java Outdated
Comment thread apm-agent-core/src/main/java/co/elastic/apm/agent/impl/ElasticApmTracer.java Outdated
@jackshirazi

Copy link
Copy Markdown
Contributor

@elasticmachine run elasticsearch-ci/docs

@jackshirazi

Copy link
Copy Markdown
Contributor

@elasticmachine run elasticsearch-ci/docs

@jackshirazi
jackshirazi enabled auto-merge (squash) March 9, 2022 16:14
@jackshirazi
jackshirazi merged commit 4f212f9 into elastic:main Mar 9, 2022
@tobiasstadler

Copy link
Copy Markdown
Contributor Author

Thank You!

@tobiasstadler
tobiasstadler deleted the fix-2083 branch March 9, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-java community Issues and PRs created by the community triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[META 496] Dropping fast exit spans

3 participants