Skip to content

Build xpack - #1645

Merged
jalvz merged 4 commits into
elastic:masterfrom
jalvz:build-xpack
Dec 14, 2018
Merged

jalvz merged 4 commits into
elastic:masterfrom
jalvz:build-xpack

Conversation

@jalvz

@jalvz jalvz commented Dec 12, 2018 •

Copy link
Copy Markdown
Contributor

No description provided.

@jalvz
jalvz requested a review from graphaelli December 12, 2018 12:57
@jalvz

jalvz commented Dec 12, 2018

Copy link
Copy Markdown
Contributor Author

The libbeat side has been merged already.

Rebase, not squash this one.

@jalvz jalvz self-assigned this Dec 12, 2018

@graphaelli graphaelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just minor issues

Comment thread Makefile
Comment thread Makefile Outdated
Comment thread Makefile
@jalvz

jalvz commented Dec 13, 2018 •

Copy link
Copy Markdown
Contributor Author

only kibana sync failing

Comment thread changelogs/head.asciidoc Outdated
- Use _doc as document type for Elasticsearch >= 7.0.0 https://github.com/elastic/beats/pull/9056[beats/9057].
- Automatically cap signed integers to 63bits https://github.com/elastic/beats/pull/8991[beats/8991].
- Add optional `span.subtype` and `span.action` properties. {pull}1618[1618].
- Build X-Pack binaries. {pull}1645[1645].

@jalvz jalvz Dec 13, 2018 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graphaelli do you think this is appropriate?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what you mean, I can't think of anything better. I'm asking around but I think you're good to merge and we can update the wording later before release so it makes sense to users.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build default distribution under the Elastic License

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, many thanks for checking!

Comment thread Makefile
Comment thread changelogs/head.asciidoc Outdated
- Use _doc as document type for Elasticsearch >= 7.0.0 https://github.com/elastic/beats/pull/9056[beats/9057].
- Automatically cap signed integers to 63bits https://github.com/elastic/beats/pull/8991[beats/8991].
- Add optional `span.subtype` and `span.action` properties. {pull}1618[1618].
- Build X-Pack binaries. {pull}1645[1645].

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what you mean, I can't think of anything better. I'm asking around but I think you're good to merge and we can update the wording later before release so it makes sense to users.

@jalvz
jalvz merged commit 45c2b0b into elastic:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants