Skip to content

Rename transaction span dropped total - #1809

Merged
graphaelli merged 9 commits into
elastic:masterfrom
graphaelli:rename-transaction-dropped-total
Jan 17, 2019
Merged

graphaelli merged 9 commits into
elastic:masterfrom
graphaelli:rename-transaction-dropped-total

Conversation

@graphaelli

@graphaelli graphaelli commented Jan 17, 2019 •

Copy link
Copy Markdown
Contributor

to be rebase with master, opening early to test a fix in CI infra

resolves #1675

Gil Raphaelli added 9 commits January 11, 2019 16:57
also defines all supported container.* and kubernetes.* now that libbeat can support it, to clean
up tests and customize field descriptions
 Conflicts:
	include/fields.go
	model/metadata/metadata.go
	processor/stream/package_tests/metadata_attrs_test.go
	processor/stream/package_tests/span_attrs_test.go
	testdata/intake-v2/errors.ndjson
	testdata/intake-v2/transactions.ndjson
	testdata/intake-v2/transactions_spans.ndjson
@graphaelli

Copy link
Copy Markdown
Contributor Author

jenkins, retest this please

@graphaelli

Copy link
Copy Markdown
Contributor Author

sync job failed, will follow up with an update as we have a bunch of these lined up.

@graphaelli graphaelli changed the title Rename transaction dropped total Rename transaction span dropped total Jan 17, 2019
@graphaelli
graphaelli merged commit e117ca8 into elastic:master Jan 17, 2019
@graphaelli
graphaelli deleted the rename-transaction-dropped-total branch January 17, 2019 20:07
simitt added a commit to simitt/kibana that referenced this pull request Jan 21, 2019
Rename `span.hex_id` and `transaction.span_count.dropped`
related to elastic/apm-server#1809
related to elastic/apm-server#1811
simitt added a commit to elastic/kibana that referenced this pull request Jan 21, 2019
Rename `span.hex_id` and `transaction.span_count.dropped`
related to elastic/apm-server#1809
related to elastic/apm-server#1811
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Rename `span.hex_id` and `transaction.span_count.dropped`
related to elastic/apm-server#1809
related to elastic/apm-server#1811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate to move transaction.span_count.dropped.total to transaction.span_count.dropped

2 participants