Repository navigation
remove regexProperties validation - #1148
Merged
Merged
Conversation
simitt
approved these changes
Jul 17, 2018
simitt
left a comment
Contributor
There was a problem hiding this comment.
I completely misunderstood the usage of regexProperties. Thanks a lot for catching this @axw and fixing it @graphaelli !
graphaelli
force-pushed
the
regex-properties
branch
from
July 17, 2018 20:40
f343c08 to
5f64c37
Compare
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Jul 17, 2018
graphaelli
pushed a commit
to graphaelli/apm-server
that referenced
this pull request
Jul 17, 2018
graphaelli
added a commit
that referenced
this pull request
Jul 17, 2018
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Jul 17, 2018
graphaelli
added a commit
that referenced
this pull request
Jul 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes requirement that certain fields are valid regexes, as reported in #909.
I introduced at least one of these rules but misunderstood this directive's actual purpose: https://github.com/santhosh-tekuri/jsonschema/blob/v1.2.2/schema.go#L319-L325
closes #909