Repository navigation
[add_kubernetes_metadata][Metricset state_namespace] Fix namespace filter - #39934
Merged
Merged
Conversation
Signed-off-by: constanca <constanca.manteigas@elastic.co>
Signed-off-by: constanca <constanca.manteigas@elastic.co>
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
5 of 6 tasks
Signed-off-by: constanca <constanca.manteigas@elastic.co>
Signed-off-by: constanca <constanca.manteigas@elastic.co>
Signed-off-by: constanca <constanca.manteigas@elastic.co>
Signed-off-by: constanca <constanca.manteigas@elastic.co>
Signed-off-by: constanca <constanca.manteigas@elastic.co>
Signed-off-by: constanca <constanca.manteigas@elastic.co>
Contributor
Author
|
The lint errors |
MichaelKatsoulis
approved these changes
Jun 20, 2024
MichaelKatsoulis
left a comment
Contributor
There was a problem hiding this comment.
Thanks for that! Just address the changelog comment.
Signed-off-by: constanca <constanca.manteigas@elastic.co>
gizas
reviewed
Jun 25, 2024
gizas
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR:
add_kubernetes_metadatawatchers.state_namespaceto also considernamespacefilter like all the other namespaced resources.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Relates to #38978.
How to test locally
Learn how to run your own filebeat here. In next section, I explain my tests.
Results
I have a cluster with two namespaces:
defaultandkube-system.This is an example of filestream using the processor filtered by namespace `default`.
The documents fields annotated with data coming from the processor need to be coming from pods inside
defaultnamespace. Checking in discover I can see:And:
So only pods from
defaultget annotated as expected.If I now remove the namespace from the processor and leave it like this:
I can see all documents get annotated with metadata:

