Skip to content

all: Update API error assertions to string - #408

Merged
marclop merged 3 commits into
elastic:masterfrom
marclop:f/update-error-asseertions
Dec 8, 2020
Merged

marclop merged 3 commits into
elastic:masterfrom
marclop:f/update-error-asseertions

Conversation

@marclop

@marclop marclop commented Dec 1, 2020

Copy link
Copy Markdown
Collaborator

Description

Updates the code with the changes introduced in elastic/cloud-sdk-go#258
and removes the old util.ReturnErrOnly.

Requires elastic/cloud-sdk-go#258 to be merged and the sdk module to be
updated.

Types of Changes

  • Refactoring (improves code quality but has no user-facing effect)

@marclop marclop self-assigned this Dec 1, 2020
Updates the code with the changes introduced in elastic/cloud-sdk-go#258
and removes the old `util.ReturnErrOnly`.

Requires elastic/cloud-sdk-go#258 to be merged and the sdk module to be
updated.

Signed-off-by: Marc Lopez <marc5.12@outlook.com>
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
@marclop
marclop force-pushed the f/update-error-asseertions branch from a09dcbe to 13add6a Compare December 7, 2020 05:58
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
@marclop
marclop marked this pull request as ready for review December 7, 2020 06:21
@marclop
marclop requested a review from a team as a code owner December 7, 2020 06:21
@marclop
marclop merged commit 0611c12 into elastic:master Dec 8, 2020
@marclop
marclop deleted the f/update-error-asseertions branch December 8, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants