Skip to content

deps: Update SDK to fix --generate-update-payload and stack list - #418

Merged
karencfv merged 2 commits into
elastic:masterfrom
karencfv:handle-empty-size-update-payload
Dec 10, 2020
Merged

karencfv merged 2 commits into
elastic:masterfrom
karencfv:handle-empty-size-update-payload

Conversation

@karencfv

@karencfv karencfv commented Dec 10, 2020 •

Copy link
Copy Markdown
Contributor

Description

Updates SDK dependency to the latest commit (fa5926f) to include
a fix for the ecctl deployment show <ID> --generate update-payload
command, where there would be a panic if a size object was empty.

Additionally, this also includes a fix where the ecctl stack list command
was not ordering versions correctly.

Related Issues

Closes: #413

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@karencfv karencfv added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 10, 2020
@karencfv karencfv self-assigned this Dec 10, 2020
@karencfv
karencfv requested a review from a team as a code owner December 10, 2020 05:36
@marclop marclop changed the title deps: Update SDK dependency to include fix for --generate-update-payload fix deps: Update SDK to fix --generate-update-payload and stack list Dec 10, 2020

@marclop marclop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karencfv
karencfv merged commit 34a7a19 into elastic:master Dec 10, 2020
@karencfv
karencfv deleted the handle-empty-size-update-payload branch December 10, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flag --generate-update-payload throws segmentation violation when showing a deployment

2 participants