Skip to content

release: v1.0.0 release notes and changelog - #350

Merged
karencfv merged 10 commits into
elastic:masterfrom
karencfv:changelog-1.0.0
Jul 30, 2020
Merged

karencfv merged 10 commits into
elastic:masterfrom
karencfv:changelog-1.0.0

Conversation

@karencfv

Copy link
Copy Markdown
Contributor

Description

Release notes and changelog for v1.0.0

Related Issues

Related: #335 and #349

Motivation and Context

GA time 🎉

Types of Changes

  • Documentation

@karencfv karencfv added documentation Improvements or additions to documentation Team:Delivery labels Jul 22, 2020
@karencfv
karencfv requested a review from nrichers July 22, 2020 06:17
@karencfv karencfv self-assigned this Jul 22, 2020
@karencfv karencfv mentioned this pull request Jul 22, 2020
20 tasks done
Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated

@nrichers nrichers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @karencfv I left some review comments for you, mostly suggested edits you can commit directly, but there are also a couple of spots where more info might be needed. I'm technically out on Monday, but can peek in at work to see if you want me to clarify anything or if you don't think a comment applies. (Happy to trust your judgement and will make sure this gets approved in time.)

Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated
Comment thread docs/release_notes/v1.0.0.adoc Outdated
@karencfv

Copy link
Copy Markdown
Contributor Author

Thanks both for the review! All comments have been addressed now :)

I just need to add more information about the --generate-payload flag that will be added, and I'll change this PR from "draft" to "ready"

@nrichers nrichers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for addressing my comments! :shipit:

@karencfv
karencfv marked this pull request as ready for review July 29, 2020 02:37
@karencfv
karencfv requested review from a team and alaudazzi as code owners July 29, 2020 02:37

@marclop marclop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left a comment which I think is a typo but could be wrong.

Comment thread docs/release_notes/v1.0.0.adoc Outdated

@marclop marclop left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-lgtm

@karencfv

Copy link
Copy Markdown
Contributor Author

Think I'll hold off on merging until we've released cloud-sdk-go v1.0.0, and updated the dependency here so that commit shows up in the changelog.

@karencfv karencfv mentioned this pull request Jul 29, 2020
8 tasks done
@karencfv
karencfv merged commit c575b64 into elastic:master Jul 30, 2020
@karencfv
karencfv deleted the changelog-1.0.0 branch July 30, 2020 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Team:Delivery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants