Repository navigation
cmd: Rename apikey to api-key and EC_API_KEY - #363
Merged
marclop merged 2 commits intoAug 14, 2020
Merged
Conversation
In order to align the environment variables to match the existing cloud documentation, this patch renames the `--apikey` flag to `--api-key`, which also makes the `EC_APIKEY` be changed to the desired `EC_API_KEY` environment variable. Signed-off-by: Marc Lopez <marc5.12@outlook.com>
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
karencfv
approved these changes
Aug 13, 2020
karencfv
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just one optional nit. the flag is --api-key but every other reference to the api key is api_key. I think it would be great to have them all be one way or the other :)
Contributor
|
btw, I think the tile of the PR is wrong 😄 |
Collaborator
Author
|
@karencfv all the cli flags use a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to align the environment variables to match the existing cloud
documentation, this patch renames the
--apikeyflag to--api-key,which also makes the
EC_APIKEYbe changed to the desiredEC_API_KEYenvironment variable.
Related Issues
elastic/terraform-provider-ec#39
Motivation and Context
Aligning the config settings across products.
Types of Changes