Skip to content

Terminate get blob retries when GCS blob store is closed - #142193

Merged
nicktindall merged 8 commits into
elastic:mainfrom
nicktindall:terminate_retries_when_gcs_blob_store_closed
Feb 11, 2026
Merged

nicktindall merged 8 commits into
elastic:mainfrom
nicktindall:terminate_retries_when_gcs_blob_store_closed

Conversation

@nicktindall

Copy link
Copy Markdown
Contributor

When we close the blob store, we shouldn't keep retrying get blob requests

@nicktindall nicktindall added >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Feb 10, 2026
@elasticsearchmachine elasticsearchmachine added v9.4.0 Team:Distributed Meta label for distributed team. labels Feb 10, 2026
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@nicktindall
nicktindall requested a review from ywangd February 10, 2026 07:38
@nicktindall nicktindall added auto-backport Automatically create backport pull requests when merged v9.3.1 labels Feb 10, 2026

@mhl-b mhl-b left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's a bit inconsisent that different repository types manage the closed state at different layers. Just noting it down. Nothing to do for this PR.

@nicktindall
nicktindall enabled auto-merge (squash) February 11, 2026 05:34
@nicktindall
nicktindall disabled auto-merge February 11, 2026 05:34
@nicktindall
nicktindall enabled auto-merge (squash) February 11, 2026 05:38
@nicktindall
nicktindall merged commit 4b4e27c into elastic:main Feb 11, 2026
35 checks passed
@nicktindall
nicktindall deleted the terminate_retries_when_gcs_blob_store_closed branch February 11, 2026 06:55
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
❌ 9.3 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 142193

nicktindall added a commit to nicktindall/elasticsearch that referenced this pull request Feb 11, 2026
)

(cherry picked from commit 4b4e27c)

# Conflicts:
#	modules/repository-gcs/src/test/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageBlobContainerRetriesTests.java
@nicktindall

Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 9.3

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Feb 11, 2026
…142279)

(cherry picked from commit 4b4e27c)

# Conflicts:
#	modules/repository-gcs/src/test/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageBlobContainerRetriesTests.java
costin pushed a commit to costin/elasticsearch that referenced this pull request Feb 16, 2026
bpintea pushed a commit to bpintea/elasticsearch that referenced this pull request Apr 29, 2026
…elastic/elasticsearch-serverless#5873)

In addition to IOException, this PR makes BlobStoreSyncDirectory to also
ignore AlreadyClosedException on deletion failures. This exception can
happen during node shutdown time where plugin lifecycle components are
closed before GatewayMetaState.

Relates elastic#142193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team. v9.3.1 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants