Repository navigation
[Inference] Correctly preserve class information for internal endpoints on update - #142380
Merged
dimitris-athanasiou merged 4 commits intoFeb 12, 2026
Conversation
…ts on update This addresses a bug introduced in elastic#140003 which causes service settings for elasticsearch internal inference endpoints to lose their subclass information and remain only as the `ElasticsearchInternalServiceSettings` parent class.
dimitris-athanasiou
marked this pull request as ready for review
February 12, 2026 11:21
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Collaborator
|
Hi @dimitris-athanasiou, I've created a changelog YAML for you. |
Jan-Kazlouski-elastic
self-requested a review
February 12, 2026 11:23
Jan-Kazlouski-elastic
left a comment
Contributor
There was a problem hiding this comment.
Left a few comments.
Haven't looked too deep into tests as they are mostly moved from existing ElasticsearchInternalServiceSettingsTests class and should be ok
Jan-Kazlouski-elastic
self-requested a review
February 12, 2026 13:12
Jan-Kazlouski-elastic
approved these changes
Feb 12, 2026
Jan-Kazlouski-elastic
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug introduced in #140003 which causes service settings for elasticsearch internal inference endpoints to lose their subclass information and remain only as the
ElasticsearchInternalServiceSettingsparent class.