Repository navigation
Conversation
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
Hi @gmarouli, I've created a changelog YAML for you. |
gmarouli
marked this pull request as ready for review
March 6, 2026 11:38
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
romseygeek
approved these changes
Mar 9, 2026
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Mar 9, 2026
…source (elastic#143726) When loading synthetic fields we use the `SourceFilter` to determine which ones will be included. However, `ObjectMapper` includes all the metadata fields as well. Usually, this is not an issue because most metadata fields do not support synthetic source. However, the `_doc_count` does and when we were displaying the dimensions in ES|QL of a downsampled index where all docs have the `_doc_count` set, it adds `_doc_count` in the output of `_timeseries`. In this PR, we change the `innerSyntheticFieldLoader` of the `ObjectMapper` to apply the filter also on the metadata. We do always include the `IgnoredSourceFieldMapper` because we need it to load the fields from it. Closes elastic#143464 (cherry picked from commit 72c2244) # Conflicts: # x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries.csv-spec # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
gmarouli
added a commit
that referenced
this pull request
Mar 9, 2026
…source (#143726) (#143851) When loading synthetic fields we use the `SourceFilter` to determine which ones will be included. However, `ObjectMapper` includes all the metadata fields as well. Usually, this is not an issue because most metadata fields do not support synthetic source. However, the `_doc_count` does and when we were displaying the dimensions in ES|QL of a downsampled index where all docs have the `_doc_count` set, it adds `_doc_count` in the output of `_timeseries`. In this PR, we change the `innerSyntheticFieldLoader` of the `ObjectMapper` to apply the filter also on the metadata. We do always include the `IgnoredSourceFieldMapper` because we need it to load the fields from it. Closes #143464 (cherry picked from commit 72c2244) # Conflicts: # x-pack/plugin/esql/qa/testFixtures/src/main/resources/k8s-timeseries.csv-spec # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading synthetic fields we use the
SourceFilterto determine which ones will be included. However,ObjectMapperincludes all the metadata fields as well.Usually, this is not an issue because most metadata fields do not support synthetic source.
However, the
_doc_countdoes and when we were displaying the dimensions in ES|QL of a downsampled index where all docs have the_doc_countset, it adds_doc_countin the output of_timeseries.In this PR, we change the
innerSyntheticFieldLoaderof theObjectMapperto apply the filter also on the metadata. We do always include theIgnoredSourceFieldMapperbecause we need it to load the fields from it.Closes #143464