Repository navigation
Fix semantic_text mapper tests for BFLOAT16 default element type - #145643
Closed
chrisparrinello wants to merge 5 commits into
Closed
chrisparrinello wants to merge 5 commits into
chrisparrinello wants to merge 5 commits into
Conversation
…epending on the IndexVersions
chrisparrinello
marked this pull request as ready for review
April 2, 2026 19:25
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Mikep86
reviewed
Apr 3, 2026
Mikep86
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking this on @chrisparrinello! I spun up a new PR with what should be a more streamlined fix:
- Fewer changes to prod code
- Cleaned up some other test code for better logic reuse
Can you take a look?
Contributor
Author
|
@Mikep86 I've taken a look at your PR and I've approved it. I'll go ahead and close this one. Thanks for taking care of this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145550 and #145591
Test failure was introduced via the change made in #144236 where BFLOAT16 is now being used for the default type for semantic text. The fix is to check the IndexSettings indirectly to see what the default type is for semanic text. Previous versions of the index can still use FLOAT.