Skip to content

SQL: fix CLI tests failures due to unconsumed output - #145967

Merged
luigidellaquila merged 5 commits into
elastic:mainfrom
luigidellaquila:esql/fix_cli_api_key
Apr 10, 2026
Merged

SQL: fix CLI tests failures due to unconsumed output#145967
luigidellaquila merged 5 commits into
elastic:mainfrom
luigidellaquila:esql/fix_cli_api_key

Conversation

@luigidellaquila

@luigidellaquila luigidellaquila commented Apr 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

SQL client always assumed to receive a stack trace for remote failures. This is no longer true with authentication exceptions after the introduction of API key auth.
The result was that the CLI did not consume the output properly.

Fixes: #143645
Fixes: #143646

@luigidellaquila
SQL: fix CLI tests failures due to unconsumed output
956f6f8 
wrong management of exceptions with no stack trace
@luigidellaquila
luigidellaquila requested a review from bpintea April 10, 2026 08:20
@luigidellaquila
luigidellaquila marked this pull request as ready for review April 10, 2026 08:21
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 10, 2026
@elasticsearchmachine

elasticsearchmachine commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine

elasticsearchmachine commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Hi @luigidellaquila, I've created a changelog YAML for you.

bpintea
bpintea approved these changes Apr 10, 2026
View reviewed changes

@bpintea bpintea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@luigidellaquila
luigidellaquila enabled auto-merge (squash) April 10, 2026 15:58
@github-actions

github-actions Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔍 Preview links for changed docs

⏳ Building and deploying preview... View progress

This comment will be updated with preview links when the build is complete.

@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@luigidellaquila
luigidellaquila merged commit 5b92126 into elastic:main Apr 10, 2026
35 checks passed
elasticsearchmachine pushed a commit that referenced this pull request Jun 8, 2026
@luigidellaquila
SQL: fix CLI tests failures due to unconsumed output (#145967) (#151009)
82202f8 
* SQL: fix CLI tests failures due to unconsumed output (#145967)

* unmute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpintea bpintea bpintea approved these changes

Assignees

No one assigned

Labels

:Analytics/SQL SQL querying >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] CliApiKeyIT testCliConnectionWithInvalidApiKey failing [CI] CliApiKeyIT testCliConnectionWithInvalidApiKey failing

4 participants

@luigidellaquila @elasticsearchmachine @bpintea @brianseeders