Skip to content

Update failure store redirect logic to exclude backpressure exceptions - #148154

Merged
jbaiera merged 8 commits into
elastic:mainfrom
jbaiera:fix-failure-store-error-filtering
May 4, 2026
Merged

jbaiera merged 8 commits into
elastic:mainfrom
jbaiera:fix-failure-store-error-filtering

Conversation

@jbaiera

@jbaiera jbaiera commented May 1, 2026

Copy link
Copy Markdown
Contributor

Updates shard-level failure redirection logic for data stream failure stores to exclude cluster block exception and circuit breaker exceptions from being captured in the failure store. Additionally, any exception that results in an HTTP 429 response is filtered from the redirection logic. These exceptions are indicative of backpressure, which is an important signal for ingestion clients.

@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Hi @jbaiera, I've created a changelog YAML for you.

@github-actions

github-actions Bot commented May 1, 2026 •

Copy link
Copy Markdown
Contributor

🔍 Preview links for changed docs

⏳ Building and deploying preview... View progress

This comment will be updated with preview links when the build is complete.

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@dakrone dakrone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left two comments

jbaiera and others added 2 commits May 1, 2026 16:42
…on.java

Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
@jbaiera jbaiera added the auto-backport Automatically create backport pull requests when merged label May 1, 2026
@jbaiera
jbaiera merged commit f2ef4de into elastic:main May 4, 2026
37 checks passed
@jbaiera
jbaiera deleted the fix-failure-store-error-filtering branch May 4, 2026 19:09
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

💚 Backport successful

Status Branch Result
✅ 9.4
✅ 9.3

elasticsearchmachine pushed a commit that referenced this pull request May 5, 2026
#148154) (#148244)

Updates shard-level failure redirection logic for data stream failure stores to exclude 
cluster block exception and circuit breaker exceptions from being captured in the 
failure store.
elasticsearchmachine pushed a commit that referenced this pull request May 6, 2026
#148154) (#148245)

Updates shard-level failure redirection logic for data stream failure stores to exclude 
cluster block exception and circuit breaker exceptions from being captured in the 
failure store.
alighahramani-alig pushed a commit to alighahramani-alig/elasticsearch that referenced this pull request May 8, 2026
elastic#148154)

Updates shard-level failure redirection logic for data stream failure stores to exclude 
cluster block exception and circuit breaker exceptions from being captured in the 
failure store.
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this pull request May 11, 2026
elastic#148154)

Updates shard-level failure redirection logic for data stream failure stores to exclude 
cluster block exception and circuit breaker exceptions from being captured in the 
failure store.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :StorageEngine/Data streams Data streams and their lifecycles Team:StorageEngine v9.3.5 v9.4.1 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants