Repository navigation
[ESQL] Add null-safety to TRange exception - #159125
Conversation
TRange will throw an invalidation exception when start or offset are null.
|
Hi @prwhelan, I've created a changelog YAML for you. |
🔍 Preview links for changed docs⏳ Building and deploying preview... View progress This comment will be updated with preview links when the build is complete. |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| return zonedDateTime.minus(amount).toInstant(); | ||
| } | ||
| throw new InvalidArgumentException("Unsupported offset type [{}]", offset.getClass().getSimpleName()); | ||
| throw new InvalidArgumentException("Unsupported offset type [{}]", offset != null ? offset.getClass().getSimpleName() : "null"); |
There was a problem hiding this comment.
I don't think we should handle null here. We should reject the query in postAnalysisPlanVerification when rangeStartValue is null.
TRange will throw an invalidation exception when start or offset are null.