Repository navigation
Conversation
Contributor
|
Documentation preview: |
Collaborator
|
Hi @jedrazb, I've created a changelog YAML for you. |
…ub.com:jedrazb/elasticsearch into support-soft-deletes-connectors-change-mapping
Contributor
Author
|
@elasticmachine merge upstream |
jedrazb
marked this pull request as ready for review
December 17, 2024 16:02
Contributor
Author
That was the single edge case I didn't cover because we have custom check (with query) for index names already in use ... fixed in 7525c99 |
timgrein
reviewed
Dec 19, 2024
timgrein
left a comment
Contributor
There was a problem hiding this comment.
Left some comments, but I think nothing preventing this PR from being merged
Co-authored-by: Tim Grein <tim@4greins.de>
…ist.json Co-authored-by: Tim Grein <tim@4greins.de>
Contributor
Author
|
@elasticmachine merge upstream |
…ub.com:jedrazb/elasticsearch into support-soft-deletes-connectors-change-mapping
seanstory
reviewed
Jan 2, 2025
8 tasks done
Contributor
Author
|
New changes:
|
Contributor
Author
|
@elasticmachine merge upstream |
navarone-feekery
approved these changes
Jan 9, 2025
navarone-feekery
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just a few questions, nothing blocking.
Contributor
Author
|
@elasticmachine merge upstream |
Collaborator
|
merge conflict between base and head |
…ub.com:jedrazb/elasticsearch into support-soft-deletes-connectors-change-mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soft deletes for connectors
Add support for soft-deletes of connectors. Why?
Changes
deletedflag in the connector index mappings, indicates whether connector has been soft deleteddelete,getandlistoperations logic to support this featureinclude_deleted=trueflag we return also deleted connectors in the responseRelated work
SystemIndexDecriptorfor connector indices soon, this will help updating mappings a lot as there is SystemIndexMappingUpdateServiceforce=trueto delete endpoint to completely remove the connector