Repository navigation
DesiredBalanceReconciler always returns AllocationStats - #122458
Merged
DiannaHohensee merged 3 commits intoFeb 19, 2025
Merged
DiannaHohensee merged 3 commits into
DiannaHohensee merged 3 commits into
Conversation
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
Collaborator
|
Hi @DiannaHohensee, I've created a changelog YAML for you. |
nicktindall
approved these changes
Feb 18, 2025
nicktindall
left a comment
Contributor
There was a problem hiding this comment.
LGTM (sorry this took so long)
Contributor
Author
|
No worries, you've been spread thin lately. Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the DesiredBalanceReconciler always returns a non-empty AllocationStats object, eliminating edge cases where the stats available to DesiredBalanceMetrics may not be updated due to some kind of throttling or the balancer being disabled via cluster settings.
Adds documentation around AllocationDecider#canRebalance(RoutingAllocation)
Closes ES-10581
I added testing to better demonstrate the what values are set in the AllocationStats. Something notable is that the totalAllocations in AllocationStats will double count relocating shards, for example. Some of the new testing also covers cases where previously an empty AllocationStats was returned: now a non-empty one is always returned.