Skip to content

Have create index return a bad request on poor formatting - #123761

Merged
elasticsearchmachine merged 14 commits into
elastic:mainfrom
benwtrent:bugfix/create-index-bad-request
Mar 6, 2025
Merged

elasticsearchmachine merged 14 commits into
elastic:mainfrom
benwtrent:bugfix/create-index-bad-request

Conversation

@benwtrent

Copy link
Copy Markdown
Contributor

closes: #123661

@benwtrent benwtrent added >bug :Core/Infra/Core Core issues without another label auto-backport Automatically create backport pull requests when merged v8.18.1 v9.0.1 v9.1.0 labels Feb 28, 2025
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 28, 2025
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Hi @benwtrent, I've created a changelog YAML for you.

@arpadkiraly
arpadkiraly requested a review from a team March 3, 2025 15:41
@alexey-ivanov-es

Copy link
Copy Markdown
Contributor

LGTM, but the added test is failing in serverless build

@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Mar 5, 2025
@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 5, 2025
@elasticsearchmachine
elasticsearchmachine merged commit a1ee3c9 into elastic:main Mar 6, 2025
@benwtrent
benwtrent deleted the bugfix/create-index-bad-request branch March 6, 2025 17:25
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.18 Commit could not be cherrypicked due to conflicts
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 123761

@benwtrent

Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 9.0
✅ 8.18

Questions ?

Please refer to the Backport tool documentation

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Mar 7, 2025
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Mar 7, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 7, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 7, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 7, 2025
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
costin pushed a commit to costin/elasticsearch that referenced this pull request Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport pending >bug :Core/Infra/Core Core issues without another label serverless-linked Added by automation, don't add manually Team:Core/Infra Meta label for core/infra team v8.18.1 v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

malformed CreateIndexRequest should return 400s

3 participants