Repository navigation
Run TransportGetLifecycleAction on local node - #126002
Merged
Merged
Conversation
This action solely needs the cluster state, it can run on any node. Relates elastic#101805
25 of 45 tasks
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @nielsbauman, I've created a changelog YAML for you. |
dakrone
approved these changes
Apr 1, 2025
dakrone
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I left one comment
| getAckTimeout(restRequest), | ||
| lifecycleNames | ||
| ); | ||
| GetLifecycleAction.Request getLifecycleRequest = new GetLifecycleAction.Request(getMasterNodeTimeout(restRequest), lifecycleNames); |
Contributor
There was a problem hiding this comment.
Shouldn't this be using getAckTimeout(restRequest) instead of the "master" variant, since it no longer goes through the master node?
Contributor
Author
There was a problem hiding this comment.
The master timeout is still relevant as we use that when we're waiting for any cluster blocks to be removed. The ack timeout was never used in this request as it was a simple GET request.
nielsbauman
enabled auto-merge (squash)
April 2, 2025 13:11
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Apr 9, 2025
This action solely needs the cluster state, it can run on any node. Relates elastic#101805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This action solely needs the cluster state, it can run on any node.
Relates #101805