Repository navigation
Check prefixes when constructing synthetic source for flattened fields - #129580
Merged
Merged
Conversation
Collaborator
|
Hi @kkrik-es, I've created a changelog YAML for you. |
kkrik-es
marked this pull request as ready for review
June 17, 2025 19:13
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
parkertimmins
approved these changes
Jun 17, 2025
parkertimmins
left a comment
Contributor
There was a problem hiding this comment.
Yep, this looks correct to me
This was referenced Jun 18, 2025
Merged
Collaborator
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Jun 18, 2025
elastic#129580) * Check prefixes when constructing synthetic source for flattened fields * Update docs/changelog/129580.yaml
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
elastic#129580) * Check prefixes when constructing synthetic source for flattened fields * Update docs/changelog/129580.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthetic source for flattened fields has object grouping logic that currently checks subfields based on their suffix (leaf name). It should also be taking into account the prefix, to avoid grouping together objects with the same leaf name but different path.
Fixes #129508