Skip to content

Configurable HTTP read and connect timeouts for url based SAML metadata resolution - #136058

Merged
ankit--sethi merged 8 commits into
elastic:mainfrom
ankit--sethi:feature/add-saml-timeouts
Oct 20, 2025
Merged

ankit--sethi merged 8 commits into
elastic:mainfrom
ankit--sethi:feature/add-saml-timeouts

Conversation

@ankit--sethi

Copy link
Copy Markdown

Adds two new http timeout properties for the SAML realm.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.3.0 labels Oct 6, 2025
@ankit--sethi ankit--sethi added >bug :Security/Security Security issues without another label and removed needs:triage Requires assignment of a team area label labels Oct 7, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Oct 7, 2025
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Hi @ankit--sethi, I've created a changelog YAML for you.

@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-security (Team:Security)

Comment thread docs/changelog/136058.yaml Outdated
@ankit--sethi ankit--sethi changed the title Fix + tests for #133542 Configurable HTTP read and connect timeouts for url based SAML metadata resolution Oct 10, 2025
@ankit--sethi
ankit--sethi requested review from a team and slobodanadamovic October 10, 2025 16:18

@slobodanadamovic slobodanadamovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the production changes and they look good to me 👍
I haven't got a chance yet to review the tests.

@slobodanadamovic

slobodanadamovic commented Oct 15, 2025 •

Copy link
Copy Markdown
Contributor

Mentioning here so it doesn't get forgotten. As a followup, we'll need to update the docs and document the new settings.

@slobodanadamovic slobodanadamovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ankit--sethi ankit--sethi added auto-backport Automatically create backport pull requests when merged v9.2.1 v9.1.6 v8.19.6 labels Oct 20, 2025
@ankit--sethi
ankit--sethi merged commit ddf9b68 into elastic:main Oct 20, 2025
40 checks passed
@elasticsearchmachine

elasticsearchmachine commented Oct 20, 2025 •

Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
✅ 8.19
✅ 9.1
✅ 9.2

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 136058

ankit--sethi pushed a commit to ankit--sethi/elasticsearch that referenced this pull request Oct 20, 2025
…ta resolution (elastic#136058)

* Fix + tests for elastic#133542

* [CI] Auto commit changes from spotless

* Update docs/changelog/136058.yaml

* update summary

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
ankit--sethi pushed a commit to ankit--sethi/elasticsearch that referenced this pull request Oct 20, 2025
…ta resolution (elastic#136058)

* Fix + tests for elastic#133542

* [CI] Auto commit changes from spotless

* Update docs/changelog/136058.yaml

* update summary

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Oct 20, 2025
…ta resolution (#136058) (#136830)

* Fix + tests for #133542

* [CI] Auto commit changes from spotless

* Update docs/changelog/136058.yaml

* update summary

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Oct 20, 2025
…ta resolution (#136058) (#136831)

* Fix + tests for #133542

* [CI] Auto commit changes from spotless

* Update docs/changelog/136058.yaml

* update summary

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
ankit--sethi pushed a commit to ankit--sethi/elasticsearch that referenced this pull request Oct 22, 2025
…ta resolution (elastic#136058)

* Fix + tests for elastic#133542

* [CI] Auto commit changes from spotless

* Update docs/changelog/136058.yaml

* update summary

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>

(cherry picked from commit ddf9b68)
ankit--sethi pushed a commit that referenced this pull request Oct 22, 2025
* Configurable HTTP read and connect timeouts for url based SAML metadata resolution (#136058)

* Fix + tests for #133542

* [CI] Auto commit changes from spotless

* Update docs/changelog/136058.yaml

* update summary

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>

(cherry picked from commit ddf9b68)

* fix merge

* fix merge
ankit--sethi pushed a commit to ankit--sethi/elasticsearch that referenced this pull request Oct 23, 2025
…ta resolution (elastic#136058)

* Fix + tests for elastic#133542

* [CI] Auto commit changes from spotless

* Update docs/changelog/136058.yaml

* update summary

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>

(cherry picked from commit ddf9b68)
chrisparrinello pushed a commit to chrisparrinello/elasticsearch that referenced this pull request Oct 24, 2025
…ta resolution (elastic#136058)

* Fix + tests for elastic#133542

* [CI] Auto commit changes from spotless

* Update docs/changelog/136058.yaml

* update summary

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this pull request Nov 3, 2025
…ta resolution (elastic#136058)

* Fix + tests for elastic#133542

* [CI] Auto commit changes from spotless

* Update docs/changelog/136058.yaml

* update summary

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
ankit--sethi pushed a commit to ankit--sethi/elasticsearch that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :Security/Security Security issues without another label Team:Security Meta label for security team v8.19.6 v9.0.9 v9.1.6 v9.2.1 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants