Repository navigation
Fix a validation message in TimeSeriesGroupByAll - #139882
Merged
leontyevdv merged 7 commits intoDec 22, 2025
Merged
leontyevdv merged 7 commits into
leontyevdv merged 7 commits into
Conversation
Only grouping functions are supported (e.g. tbucket) for group-by-all queries
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @leontyevdv, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
leontyevdv
commented
Dec 22, 2025
Contributor
Author
There was a problem hiding this comment.
Auto commit changes from spotless
kkrik-es
reviewed
Dec 22, 2025
| if (Functions.isGrouping(Alias.unwrap(grouping)) == false) { | ||
| throw new IllegalArgumentException( | ||
| "Cannot mix time-series aggregate and grouping attributes. Found [" + grouping.sourceText() + "]." | ||
| "Only grouping functions are supported (e.g. tbucket). Found [" + grouping.sourceText() + "]." |
Member
There was a problem hiding this comment.
maybe "... when the time series aggregation function [" + ts_agg + "] is not wrapped with another aggregation function.
It'd be nice to convey that this the only the case where the usual example of agg(ts_agg) is not used.
Contributor
Author
There was a problem hiding this comment.
Improved! Thanks!
kkrik-es
approved these changes
Dec 22, 2025
Only grouping functions are supported (e.g. tbucket) for group-by-all queries
…ouping-functions-are-supported' into fix/group-by-all-message-only-grouping-functions-are-supported
Only grouping functions are supported (e.g. tbucket) for group-by-all queries
…ions-are-supported
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
leontyevdv
added a commit
to leontyevdv/elasticsearch
that referenced
this pull request
Dec 22, 2025
Only grouping functions are supported (e.g. tbucket) for group-by-all queries (cherry picked from commit 8f62075)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change a message that is used in the exception inside the validation loop: "Only grouping functions are supported (e.g. tbucket)."