Repository navigation
GA chunk_rescorer in text_similarity_reranker - #139830
Merged
kderusso merged 2 commits intoDec 19, 2025
Merged
Conversation
kderusso
commented
Dec 19, 2025
| `chunking_settings` | ||
| : (Optional, `object`) | ||
|
|
||
| Settings for chunking text into smaller passages for scoring and reranking. {applies_to}`stack: beta 9.2` By default, chunking settings are configured to fit within the token window of the model associated with the `inference_id`. Refer to the [Inference API documentation](https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-inference-put#operation-inference-put-body-application-json-chunking_settings) for valid values for `chunking_settings`. |
Member
Author
There was a problem hiding this comment.
@mridula-s109 removed this as the tag is at the top
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
Collaborator
|
Hi @kderusso, I've created a changelog YAML for you. |
Contributor
🔍 Preview links for changed docs |
Contributor
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 24, 2026
…#147371) ## Summary Reverts #147297. The new single-file caching path calls `object.lastModified().toEpochMilli()` in `ExternalSourceResolver#resolveSource`, but `StorageObject.lastModified()` returns `null` for the GCS and Azure fixtures exercised by `external-basic.csv-spec`, causing an NPE that cascades to 2,300–2,900 test failures per affected run. The failure is deterministic — every PR rebased onto `main` after #147297 merged has been failing `part-5` identically for ~8 hours. Confirmed across 6+ unrelated PRs including the author's own pre-merge CI build ([#139830](https://buildkite.com/elastic/elasticsearch-pull-request/builds/139830), both initial run and smart retry). Reverting to unblock the merge queue. Re-land after null-guarding `lastModified()` (or gating on `StorageProvider#supportsStableMetadata()` for the cache path as the PR intended — currently `isCacheable()` checks `supportsStableMetadata()` but all non-HTTP providers return the default `true`, which doesn't match reality for the GCS/Azure fixtures). ## Test plan - [ ] `:x-pack:plugin:esql-datasource-csv:qa:javaRestTest` — `external-basic` subset green. - [ ] `:x-pack:plugin:esql:qa:server:multi-node:javaRestTest` — `ExternalDistributedSpecIT.external-basic.*` green. - [ ] Full `part-5` recovers on CI.
dnhatn
pushed a commit
to dnhatn/elasticsearch
that referenced
this pull request
Apr 24, 2026
…47297)" (elastic#147371) ## Summary Reverts elastic#147297. The new single-file caching path calls `object.lastModified().toEpochMilli()` in `ExternalSourceResolver#resolveSource`, but `StorageObject.lastModified()` returns `null` for the GCS and Azure fixtures exercised by `external-basic.csv-spec`, causing an NPE that cascades to 2,300–2,900 test failures per affected run. The failure is deterministic — every PR rebased onto `main` after elastic#147297 merged has been failing `part-5` identically for ~8 hours. Confirmed across 6+ unrelated PRs including the author's own pre-merge CI build ([elastic#139830](https://buildkite.com/elastic/elasticsearch-pull-request/builds/139830), both initial run and smart retry). Reverting to unblock the merge queue. Re-land after null-guarding `lastModified()` (or gating on `StorageProvider#supportsStableMetadata()` for the cache path as the PR intended — currently `isCacheable()` checks `supportsStableMetadata()` but all non-HTTP providers return the default `true`, which doesn't match reality for the GCS/Azure fixtures). ## Test plan - [ ] `:x-pack:plugin:esql-datasource-csv:qa:javaRestTest` — `external-basic` subset green. - [ ] `:x-pack:plugin:esql:qa:server:multi-node:javaRestTest` — `ExternalDistributedSpecIT.external-basic.*` green. - [ ] Full `part-5` recovers on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GA's chunk rescorer and adds warnings about usage.